Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates based on WES reviewer comments #63

Merged
merged 10 commits into from
Sep 10, 2021

Conversation

nikhar-abbas
Copy link
Collaborator

Description and Purpose

This brings in some updates that have been made based on reviewer comments to the WES-preprint about ROSCO:
https://wes.copernicus.org/preprints/wes-2021-19/

Two major changes:

  1. Use the nacelle fore-aft translational velocity signal rather than the nacelle fore-aft angular velocity for the floating feedback term to be more consistent with the standard bladed interface
  2. Update the controller tuning methods so that the system pole is modified in above-rated operation when the generator torque controller is set to constant-power operation

One minor change:

  1. The TSR was not saturated properly in region 2.5, so it would stay constant even though the wind speed would be increasing and the rotor speed was constant. Now the TSR drops appropriately.

Type of change

What types of change is it?
Select the appropriate type(s) that describe this PR

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (non-backwards-compatible fix or feature)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Documentation update
  • Maintenance update
  • Other (please describe)

Github issues addressed, if one exists

Examples/Testing, if applicable

Standard tests should pass

@dzalkind dzalkind mentioned this pull request Sep 10, 2021
12 tasks
@nikhar-abbas nikhar-abbas merged commit 78dc916 into NREL:oneROSCO2 Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant