Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes UnitarySystemPerformance:Multispeed number of cooling speeds w/ Coil:Cooling:DX #5337

Merged
merged 3 commits into from
Jan 7, 2025

Conversation

shorowit
Copy link
Contributor

@shorowit shorowit commented Dec 25, 2024

Pull request overview

Fixes the number of cooling speeds forward translated in the UnitarySystemPerformance:Multispeed object when you use a Coil:Cooling:DX object.

Confirmed the fix in OpenStudio-HPXML:
image

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

…tispeed object when you use a CoilCoolingDX object.
@shorowit shorowit added component - HVAC Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. labels Dec 25, 2024
@shorowit shorowit self-assigned this Dec 25, 2024
@shorowit shorowit marked this pull request as ready for review December 25, 2024 02:04
@shorowit shorowit requested a review from jmarrec December 25, 2024 02:05
@jmarrec jmarrec merged commit afef7c9 into develop Jan 7, 2025
4 of 6 checks passed
@jmarrec jmarrec deleted the coil_cooling_dx_multispeed branch January 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - HVAC Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants