-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrap GroundHeatExchangerVertical "Depth of Top of Borehole" field #5325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
added
Enhancement Request
component - Model
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
IDDChange
labels
Dec 18, 2024
jmarrec
reviewed
Dec 19, 2024
src/energyplus/ForwardTranslator/ForwardTranslateGroundHeatExchangerVertical.cpp
Outdated
Show resolved
Hide resolved
jmarrec
force-pushed
the
ghe-borehole-top-depth
branch
from
December 19, 2024 10:54
c754e3e
to
a0827aa
Compare
…nto ghe-borehole-top-depth
jmarrec
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the test compiles, this looks great and ready to merge
src/energyplus/ForwardTranslator/ForwardTranslateGroundHeatExchangerVertical.cpp
Show resolved
Hide resolved
…epth and resolve conflicts
I merged develop in, and resolved conflicts. |
K I think I fixed all tests, I assume CI will be green in a few minutes and we can merge. |
CI Results for 1ff4566:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component - Model
Enhancement Request
IDDChange
Pull Request - Ready for CI
This pull request if finalized and is ready for continuous integration verification prior to merge.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Pull Request Author
src/model/test
)src/energyplus/Test
)src/osversion/VersionTranslator.cpp
)Labels:
IDDChange
APIChange
Pull Request - Ready for CI
so that CI builds your PRReview Checklist
This will not be exhaustively relevant to every PR.