Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap GroundHeatExchangerVertical "Depth of Top of Borehole" field #5325

Merged
merged 19 commits into from
Dec 23, 2024

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Dec 18, 2024

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@joseph-robertson joseph-robertson added Enhancement Request component - Model Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. IDDChange labels Dec 18, 2024
@joseph-robertson joseph-robertson self-assigned this Dec 18, 2024
src/model/test/GroundHeatExchangerVertical_GTest.cpp Outdated Show resolved Hide resolved
src/model/GroundHeatExchangerVertical_Impl.hpp Outdated Show resolved Hide resolved
src/model/GroundHeatExchangerVertical_Impl.hpp Outdated Show resolved Hide resolved
src/model/GroundHeatExchangerVertical.cpp Show resolved Hide resolved
resources/model/OpenStudio.idd Outdated Show resolved Hide resolved
src/osversion/VersionTranslator.cpp Show resolved Hide resolved
@jmarrec jmarrec force-pushed the ghe-borehole-top-depth branch from c754e3e to a0827aa Compare December 19, 2024 10:54
Copy link
Collaborator

@jmarrec jmarrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once the test compiles, this looks great and ready to merge

@jmarrec jmarrec marked this pull request as ready for review December 20, 2024 07:44
@jmarrec
Copy link
Collaborator

jmarrec commented Dec 23, 2024

I merged develop in, and resolved conflicts.

@jmarrec
Copy link
Collaborator

jmarrec commented Dec 23, 2024

K I think I fixed all tests, I assume CI will be green in a few minutes and we can merge.

@jmarrec jmarrec merged commit b57dba6 into develop Dec 23, 2024
3 of 6 checks passed
@jmarrec jmarrec deleted the ghe-borehole-top-depth branch December 23, 2024 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component - Model Enhancement Request IDDChange Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrap GroundHeatExchangerVertical "Depth of Top of Borehole" field
3 participants