Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two analyses at a time #755

Merged
merged 6 commits into from
Apr 14, 2024
Merged

Two analyses at a time #755

merged 6 commits into from
Apr 14, 2024

Conversation

brianlball
Copy link
Contributor

@brianlball brianlball commented Apr 9, 2024

#717
#753

Running 2 analyses Resque queues in the web-background container can cause out of order ResqueJobs::RunAnalysis jobs.
For example, when an LHS analysis is submitted to OSAF, it is actually two jobs. The first is analysis_type='lhs' followed by analysis_type='batch_run'. see batch_run_methods. They are both Resque.enqueue'd right after each other, but there are no hooks or requirements that one goes before the other. With only 1 Resque Worker in the web-background container, only one job in the analyses queue is run at a time, the first being the non-batch_run analysis_type.

If there are 2 Resque workers in the web-background container, either by changing start-web-background.sh or helm-chart, batch_run.perform can start before lhs.perform can complete which results in datapoints trying to be run before they are made.

This is how it should work, where LHS generates the datapoints and batch_run then data_point.submit_simulation:

orig_order

VS

This is what can happen with 2 analysis queues right now, batch_run has no datapoints to submit because lhs has not created them yet:

2wb_order

@brianlball
Copy link
Contributor Author

brianlball commented Apr 9, 2024

image

@brianlball
Copy link
Contributor Author

brianlball commented Apr 9, 2024

parallel analyses with the new test

image

@brianlball
Copy link
Contributor Author

#618

Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow, this is fancy! Good work figuring out and fixing!

@brianlball brianlball merged commit bc22204 into requeue Apr 14, 2024
11 checks passed
@brianlball brianlball deleted the two_analyses branch April 14, 2024 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants