-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Two analyses at a time #755
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parallel analyses with the new test |
This was referenced Apr 9, 2024
nllong
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wow, this is fancy! Good work figuring out and fixing!
…eue; otherwise for large batches, there can be overlap in the sim queue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#717
#753
Running 2 analyses Resque queues in the web-background container can cause out of order ResqueJobs::RunAnalysis jobs.
For example, when an LHS analysis is submitted to OSAF, it is actually two jobs. The first is
analysis_type='lhs'
followed byanalysis_type='batch_run'
. see batch_run_methods. They are both Resque.enqueue'd right after each other, but there are no hooks or requirements that one goes before the other. With only 1 Resque Worker in the web-background container, only one job in the analyses queue is run at a time, the first being the non-batch_run
analysis_type
.If there are 2 Resque workers in the web-background container, either by changing start-web-background.sh or helm-chart,
batch_run.perform
can start beforelhs.perform
can complete which results in datapoints trying to be run before they are made.This is how it should work, where
LHS generates the datapoints
andbatch_run
thendata_point.submit_simulation
:VS
This is what can happen with 2 analysis queues right now,
batch_run
has no datapoints to submit becauselhs
has not created them yet: