Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup GitHub actions #617

Merged
merged 38 commits into from
Jan 25, 2021
Merged

Setup GitHub actions #617

merged 38 commits into from
Jan 25, 2021

Conversation

tijcolem
Copy link
Contributor

@tijcolem tijcolem commented Jan 20, 2021 •
edited
Loading

Resolves #616

https://travis-ci.org/ is shutting down and moving to travis-ci.com which uses a credit based system, at least for MacOS runs.
This PR uses GitHub actions to run the Linux and MacOS jobs in replace of Travis. Appeyor CI jobs will remain the same and continue to run there unless something changes. GitHub actions does support Windows instances so we could move 100% of our CI jobs there if desired.

Once all tests are passing and PR is approved we can disable the Travis CI jobs.

Checklist for GitHub Actions CI jobs:

  • Run unit tests, integration, gem packaging and uploads for MacOS 10.15
  • Run unit tests, integration, gem packaging and uploads for Ubuntu 18.04
  • Run integration tests (algo models) on docker compose stack. Uploads docker images. Ubuntu 18.04
  • Removed xcode 10.2 / osx 10.14 runs as these images are not available on GitHub actions.
  • Github actions is configured to build Pull Requests and pushes to any branch (same as was on Travis).

tijcolem added 30 commits January 7, 2021 17:45
@tijcolem
intial commit to test one job for Github actions
44eb576
@tijcolem
fix envs
6540fa5
@tijcolem
exclude this branch while testing github actions
7a1237d
@tijcolem
Copy the travis CI scripts and re-use for github actions
db22467
@tijcolem
Overwite ruby with custom version. Add new checks in bash
5fb3ae8
@tijcolem
run the unit tests now that setup is complete
c4fe2b3
@tijcolem
fix old travis envs
b6f2dd2
@tijcolem
add in step to print the logs
d38eb00
@tijcolem
print logs on failure
923a70c
@tijcolem
Change the env BUILD_TYPE to GITHUB_JOB
5d86045
@tijcolem
Add in the linux integration steps and use the BUILD_TYPE vs the GITH…
90d1e5a 
…UB_JOB env to id the build
@tijcolem
use proper syntax for assigning envs via github actions
0f4f5cd
@tijcolem
add docker integration tests
8f6617c
@tijcolem
add and enable docker-compose COMPOSE_INTERACTIVE_NO_CLI for CI
ba61a78
@tijcolem
Add the docker-compose setup script as the built-on github action doc…
91a298e 
…ker-compose is not working
@tijcolem
fix bash check for platform and build_type
82a0fcb
@tijcolem
add option to docker-compose to hopefully remove error on Github actions
2596a93
@tijcolem
Add and test out macos builds. Comment out linux builds for now as th…
847f2aa 
…at's all working fine
@tijcolem
For mac builds, use the tar.gz openstudio files as mac 10.15 is havin…
a9d1ac9 
…g errors trying to headless install the OpenStudio.dmg. Error msg: "Unable to create basic Accelerated OpenGL renderer."
@tijcolem
install core utils for macos for building nokogiri
d0e4b30
@tijcolem
fix the tar
967c12d
@tijcolem
fix the curl output file name of OpenStudio
74b3f08
@tijcolem
almost there. adding suffix
f398f4b
@tijcolem
Setup is now working for osx. update the test.sh for osx
ec414f0
@tijcolem
adding integration tests for macos
4faa85b
@tijcolem
Use one job to string together the build, unit, integration and final…
55f01ae 
…ly uploading gem packages. This should save some time with the uploading as we don't have to call the setup.sh again
@tijcolem
fix yml
2c2b45c
@tijcolem
change -uses to uses
8f930a7
@tijcolem
fixup mac export script
691c8e3
@tijcolem
export to non repo dir and then cp back to repo dir
052d003
@tijcolem tijcolem requested a review from nllong January 22, 2021 00:18
nllong
nllong approved these changes Jan 22, 2021
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you did a bunch of work to make this happen--good job!

Should we delete the ci/travis folder?

bin/resources/local/rspec_command
@@ -86,7 +86,7 @@ rspec_path = File.absolute_path(File.join(__FILE__, './../../../../gems/bin/rspe
::ENV['OS_SERVER_LOG_PATH'] = File.join(output_dir, 'logs', 'rails.log')
::ENV['RAILS_ENV'] = 'local-test'

#If this is a travis build and it's BUILD_TYPE=test we want to omit the openstudio_algo_spec.rb tests
#If this is a CI build (travis, github actions, etc..) and the BUILD_TYPE=test omit the openstudio_algo_spec.rb tests
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ci/github-actions/cipher.rb Outdated
salt = "8 octets" # or nil
text = "abcdefghijklmnopqrstuvwxyz"

crypt_by_password(alg, pass, salt, text)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line ending needed

ci/github-actions/cipher.rb Outdated
@@ -0,0 +1,54 @@
#!/usr/bin/env ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is a new file to provide some basic salting/hashing of our passwords

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've had some issues with openssl in the past so @anyaelena added this as a sanity check during the gem builds.

ci/github-actions/export_build_linux.sh
@@ -0,0 +1,20 @@
# empty dir for export
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet! finally building package from the CI!

@tijcolem
Copy link
Contributor Author

@nllong We can remove the ci/travis folder. I left it in the event we needed to move back during the time of transition, but like all "temporary" things, it'll just live there indefinitely if we don't take care of it now. =) I'll make this change.

@nllong
Copy link
Member

nllong commented Jan 22, 2021

@nllong We can remove the ci/travis folder. I left it in the event we needed to move back during the time of transition, but like all "temporary" things, it'll just live there indefinitely if we don't take care of it now. =) I'll make this change.

Cool, thanks. Likewise, are we deprecating AppVeyor in favor of Windows GH actions.

@tijcolem
Copy link
Contributor Author

AppVeyor remains the same. For now anyway. I like the RDP debug features that AppVeyor provides (used it many times), so unless they make changes like Travis, I'd vote to keep it the same. GitHub actions seems to provide the same debuging capabilities - https://github.com/stascorp/rdpwrap - but this doesn't seem as easy to enable/disable like AppVeyor.

@tijcolem
Copy link
Contributor Author

tijcolem commented Jan 25, 2021 •
edited
Loading

Okay, travis CI is now removed and disabled.

@tijcolem tijcolem merged commit f86d1ba into develop Jan 25, 2021
@tijcolem tijcolem deleted the setup_github_actions branch January 25, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees
No one assigned
Labels
Developer Issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move Linux and MacOS CI jobs to GitHub Actions
2 participants
@tijcolem @nllong