Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenStudio runs in a child of the spawned process. We need to kill bo… #462

Merged
merged 8 commits into from
Feb 27, 2019
Merged

OpenStudio runs in a child of the spawned process. We need to kill bo… #462

merged 8 commits into from
Feb 27, 2019

Conversation

anyaelena
Copy link
Member

…th on timeout.

Fixes #461

Prior to merging, i want to implement #460 and use use a very low timeout in a test for this issue.

@coveralls
Copy link

coveralls commented Jan 29, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.1%) to 66.351% when pulling 774b6c8 on timeout into c5b1044 on develop.

@anyaelena anyaelena requested a review from nllong February 21, 2019 21:37
nllong
nllong approved these changes Feb 26, 2019
View reviewed changes
Copy link
Member

@nllong nllong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

nllong and others added 2 commits February 26, 2019 16:44
@nllong
fix travis
3a883fc
@nllong
Update Gemfile
a1cf7c9 
Match version on windows
@nllong nllong force-pushed the timeout branch 3 times, most recently from 7797723 to a5e52de Compare February 27, 2019 15:46
@anyaelena anyaelena merged commit 062104a into develop Feb 27, 2019
@anyaelena anyaelena deleted the timeout branch February 27, 2019 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nllong nllong nllong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@anyaelena @coveralls @nllong