Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensuring openstudio.exe discovery process on Windows is reflected in Appveyor #405

Closed
rHorsey opened this issue Sep 17, 2018 · 2 comments
Closed

Comments

@rHorsey
Copy link
Contributor

rHorsey commented Sep 17, 2018

General Issue / Feature Information

Description

There has been a bug due to Appveyor being unable to find openstudio.exe. See #403 for the log file in question. It's unclear how the openstudio.exe file should be found on the appveyor file system. @axelstudios suggests that setting $PATH may not actually reflect how OpenStudio itself installs on Windows. Given this, I would like to ensure some degree of parity in the testing environment regarding how openstudio.exe discovery.

Expected outcome:

OpenStudio install process configuration reflected in how the openstudio.exe file location is specified in the Appveyor environment.

Other information (i.e. issue is intermittent):

This issue may/should result in explicit tests regarding discovery of openstudio.exe.

@rHorsey
Copy link
Contributor Author

rHorsey commented Sep 18, 2018

This is being addressed by two PRs: #393 and NREL/OpenStudio-PAT#95 - the phillosphy is that PAT knows where the openstudio cli exe is, just as it knows where the energyplus exe is, and so the openstudio cli exe will be passed to the child processes as an envvar through the meta-cli, just as the energyplus exe is.

@rHorsey rHorsey self-assigned this Sep 18, 2018
@rHorsey rHorsey closed this as completed Sep 25, 2018
@rHorsey
Copy link
Contributor Author

rHorsey commented Sep 25, 2018

Completed by PR #407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant