Appveyor VMs not failing when unable to discover openstudio.exe

[rHorsey]

General Issue / Feature Information

Description
While debugging the appveyor builds using the rdp functionality it was discovered that in the integration test routine each datapoint failed (as it was unable to find openstudio.exe on the path) however this error was not ultimately manifest in an exit code 1 from the test. It is unclear why the checks for ensuring each datapoint detailed status returns completed_successful did not error out.
Reproduction steps:

1. Rebuild appveyor (see https://ci.appveyor.com/project/NREL_CBRG/openstudio-server/build/1.0.378-2.6.2)
2. Use RDP to log into the box
3. Remove the commands that remove logs in the integration-test.ps1
4. Given that the ruby version is set in the appveyor template, set the ruby version in the path directly in the integration-test.ps1, in this case to "C:\Ruby224-x64\bin
5. Run C:\projects\openstudio-server\ci\appveyor\integration-test.ps1 in the PowerShell ISE
6. Review the datapoint simulation log files (of the form C:\projects\openstudio-server\spec\files\temp_data\analysis_aid\data_point_dpid\dpid.log)

Actual outcome:
One of the datapoint simulation logs (in this case from C:\projects\openstudio-server\spec\files\temp_data\analysis_1040b708-24db-49a4-abf6-8946abf29025\data_point_45114767-484d-499e-b452-91ae2f0e95bb\45114767-484d-499e-b452-91ae2f0e95bb.log)

# Logfile created on 2018-09-17 19:39:00 +0000 by logger.rb/47272
[19:39:00.551406 INFO] Checking for presence of args file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/initialize.args
[19:39:00.551406 INFO] Checking for presence of script file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/initialize.sh
[19:39:00.564413 INFO] Server host is http://localhost:8080
[19:39:00.565408 INFO] Analysis directory is C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025
[19:39:00.565408 INFO] Simulation directory is C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f
[19:39:00.565408 INFO] Run datapoint type/file is 
[19:39:00.565408 INFO] Starting initialize_worker for datapoint e4e10f2b-34f2-47ce-9077-46160cf1d09f
[19:39:00.567407 INFO] Downloading analysis zip from http://localhost:8080/analyses/1040b708-24db-49a4-abf6-8946abf29025/download_analysis_zip
[19:39:01.763058 INFO] Extracting analysis zip to C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025
[19:39:01.822055 INFO] Downloading analysis.json from http://localhost:8080/analyses/1040b708-24db-49a4-abf6-8946abf29025.json
[19:39:02.898313 DEBUG] Running datapoint initialization file if present.
[19:39:02.898313 INFO] Checking for presence of args file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/initialize.args
[19:39:02.898313 INFO] Checking for presence of script file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/initialize.sh
[19:39:02.899308 INFO] Finished worker initialization
[19:39:03.953326 INFO] Downloading datapoint from http://localhost:8080/data_points/e4e10f2b-34f2-47ce-9077-46160cf1d09f.json
[19:39:05.011856 INFO] Creating Workflow Manaager instance
[19:39:05.011856 INFO] Directory is C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f
[19:39:05.011856 INFO] Opening run.log file 'C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f/run/run.log'
[19:39:05.011856 INFO] Running workflow using cmd openstudio.exe run --workflow C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f/data_point.osw --debug
[19:39:05.033856 ERROR] Workflow C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f/data_point.osw failed with error No such file or directory - openstudio.exe run --workflow C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f/data_point.osw --debug
[19:39:05.046863 INFO] Uploading C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/data_point_e4e10f2b-34f2-47ce-9077-46160cf1d09f/run/data_point.zip which exists? false
[19:39:05.048108 INFO] Checking for presence of args file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/finalize.args
[19:39:05.048108 INFO] Checking for presence of script file at C:/projects/openstudio-server/spec/files/temp_data/analysis_1040b708-24db-49a4-abf6-8946abf29025/scripts/data_point/finalize.sh
[19:39:05.048857 INFO] Finished C:/projects/openstudio-server/server/app/jobs/dj_jobs/run_simulate_data_point.rb

Expected outcome:
No error in the above log

Other information (i.e. issue is intermittent):

Error on Local Server Details

Client operating system version:

Windows Server 2012R2

OpenStudio Server providence

Server SHA 81e7971

Local log files

I can't figure out how to SCP them back - sorry!

[rHorsey]

Closed by #407