Fixes whole MF building bug when zero occupants in one unit #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…om being treated like zero occupants for every unit.
10 tasks
…L/OpenStudio-HPXML into whole-mf-bldg-zero-occupants
|
@joseph-robertson This gives identical results in ResStock, with one exception. As demonstrated in this commit, the previous implementation was correctly zeroing out ceiling fan electricity usage, but was not disabling the ceiling fan setpoint offset. So this PR will cause a small change in homes that have zero occupants and ceiling fans, and use a ceiling fan setpoint offset. |
joseph-robertson
approved these changes
Dec 20, 2024
…o whole-mf-bldg-zero-occupants # Conflicts: # Changelog.md # HPXMLtoOpenStudio/measure.xml
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Fixes zero occupants specified for one unit in a whole MF building from being treated like zero occupants for every unit.
The previous approach, in which we use a year-round vacancy period, was fine until we started modeling whole MF buildings. But it applies to the entire building, so that doesn't work for a MF building with units that have varying numbers of occupants. Now we explicitly zero out target end uses.
Checklist
Not all may apply:
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run