Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manual J more improvements for OS-HPXML 1.9.1 #1891

Merged
merged 12 commits into from
Dec 9, 2024

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Nov 25, 2024

Pull Request Description

After these changes, OS-HPXML can now be used for ACCA Manual J approval.

Checklist

Not all may apply:

  • Schematron validator (EPvalidator.xml) has been updated
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., HPXMLtoOpenStudio/tests/test*.rb and/or workflow/tests/test*.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results of sample files

@yzhou601 yzhou601 self-assigned this Nov 25, 2024
@shorowit shorowit changed the base branch from master to oshpxml_191 December 6, 2024 22:56
@shorowit shorowit changed the base branch from oshpxml_191 to master December 6, 2024 22:56
@shorowit shorowit changed the title Manual J more improvements Manual J more improvements for OS-HPXML 1.9.1 Dec 6, 2024
@shorowit shorowit marked this pull request as ready for review December 7, 2024 00:25
Copy link
Contributor

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It all looks good to me. Nice bugfix and nice code simplification as well. This can merge in once my latest commit gets a ✔.

@shorowit shorowit merged commit 94d6687 into master Dec 9, 2024
7 checks passed
@shorowit shorowit deleted the manual_j_more_improvements branch December 9, 2024 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants