Allow building site inputs #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r code uses the HPXML inputs (or defaults) instead of the EPWFile values.
BuildResidentialScheduleFile/tests/test_build_residential_schedule_file.rb
Outdated
Show resolved
Hide resolved
…o site_inputs # Conflicts: # BuildResidentialHPXML/measure.xml # HPXMLtoOpenStudio/measure.xml # workflow/tests/base_results/results_workflow_simulations1.csv # workflow/tests/base_results/results_workflow_simulations1_bills.csv
BuildResidentialScheduleFile/tests/test_build_residential_schedule_file.rb
Outdated
Show resolved
Hide resolved
joseph-robertson
approved these changes
Mar 1, 2024
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allow building site inputs; this is particularly useful when the building is located far from, or at a very different elevation than, the EPW weather station. When not provided, defaults to using EPW header values (as before).
Some code was refactored to help ensure that our code uses the HPXML inputs (or defaults) rather than directly using EPW values.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedopenstudio tasks.rb update_hpxmls)HPXMLtoOpenStudio/tests/test*.rband/orworkflow/tests/test*.rb)openstudio tasks.rb update_measureshas been run