Fix possible simulation error related to EPW path. #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shorowit
commented
Oct 3, 2023
Comment on lines
-85
to
+86
| epw_path = hpxml.climate_and_risk_zones.weather_station_epw_filepath | ||
| epw_filepath = hpxml.climate_and_risk_zones.weather_station_epw_filepath | ||
| abs_epw_path = File.absolute_path(epw_filepath) |
There was a problem hiding this comment.
This is the bugfix, the rest is cleanup. If the HPXML file is in your current working directory and the EPW path in the HPXML file is a relative path, epw_path will also end up as a relative path and get written to the OSM as a relative path. This causes downstream problems since the OSM ends up in a different directory, so the weather file is no longer relative to it. So the bugfix is to make sure we always convert the epw_path to an absolute path for the OSM.
There was a problem hiding this comment.
Note that in most situations, the relative path was correctly ending up as an absolute path in the OSM. But in this one particular situation, it wasn't.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Closes #1497.
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
EPvalidator.xml) has been updatedtasks.rb)HPXMLtoOpenStudio/testsand/orworkflow/tests/hpxml_translator_test.rb)openstudio tasks.rb update_measureshas been run