Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasOutdoorAirControl input for CFIS systems #746

Merged
merged 12 commits into from
Oct 22, 2024
Merged

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Oct 22, 2024

Pull Request Description

[description here]

Checklist

Not all may apply:

  • OS-HPXML git subtree has been pulled
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Sample files have been added/updated (openstudio tasks.rb update_hpxmls)
  • Tests have been added/updated (e.g., rulesets\tests and/or workflow/tests/*_test.rb)
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected changes to simulation results on CI

a38d474e51 Latest results.
674ea6907c Latest results.
60e80ec157 When a CFIS system has no outdoor air control, include outdoor air during all heating/cooling runtime.
ad3465f9ec Merge branch 'cfis_oa_control' of https://github.com/NREL/OpenStudio-HPXML into cfis_oa_control
2c9a13eefb Some code refactor/cleanup.
fd1414164b Latest results.
1556c50cf0 Update tests
47e4923e93 Bugfix.
b2a64fc3f6 Merge branch 'cfis_oa_control' of https://github.com/NREL/OpenStudio-HPXML into cfis_oa_control
161f870902 Some initial code cleanup; no diffs expected.
f3243c405f Latest results.
70a5f49fe5 Update test.
deb2824e85 Initial scaffolding. Still need to use it in the energy model.
27dd8ead49 Merge pull request #1861 from NREL/utility_bills_update
24409402f4 Bugfixes: 1. Don't overwrite max usage units in the tariffs we produce. 2. Only throw an error if the max usage unit is not kWh AND a max usage value is provided. The units apply to the max value usage only, the rate value is always $/kWh; see the OpenEI URDB website for confirmation.
2de51a2a82 Merge pull request #1857 from NREL/hpwh_capacities
5c3fc8163f Update Changelog.md
35ba1cbeea Updates utility bill calculations to allow daily fixed charges. Improves warning messages. A little code cleanup.
67301d72bd Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into hpwh_capacities
301ae67c05 Pin ubuntu-22.04 while GitHub works on fixing ubuntu-latest.
bd4bde15d4 Require a water heater's HeatingCapacity to be > 0.
2dd566f7e6 Merge pull request #1816 from NREL/cfis_continued
09c7cd1860 Fix CI
616154a2ae Latest results.
906db6c7e4 A little cleanup.
578929efb9 Merge branch 'cfis_continued' of https://github.com/NREL/OpenStudio-HPXML into hpwh_capacities
bb8d8b0256 Fix CI
68a9e3fef5 Latest results.
a2f595de28 Fixes CI?
77467c7a92 A little docs cleanup.
40d7e93844 Allows optional `HeatingCapacity` and `BackupHeatingCapacity` inputs for HPWHs. Defaults same as before.
ca3bdf5955 Merge branch 'cfis_continued' of https://github.com/NREL/OpenStudio-HPXML into cfis_continued
da7f967873 Clean up docs [ci skip]
7b79e72296 Latest results.

git-subtree-dir: hpxml-measures
git-subtree-split: a38d474e51a7008e4ec5cd997bbe02d140fe7153
@shorowit shorowit self-assigned this Oct 22, 2024
shorowit and others added 8 commits October 21, 2024 22:02
c79ef9a131 Merge branch 'cfis_oa_control' of https://github.com/NREL/OpenStudio-HPXML into cfis_oa_control
06c45accbf Bugfix.

git-subtree-dir: hpxml-measures
git-subtree-split: c79ef9a131abbce8a3898cbea0b1cfe49b7e8706
9332bad71e Merge pull request #1863 from NREL/cfis_oa_control
219d264362 Clarify emittance and solar absorptance inputs. [ci skip]

git-subtree-dir: hpxml-measures
git-subtree-split: 9332bad71e81cca1ed953c89b35f84bd45f2281a
@shorowit shorowit marked this pull request as ready for review October 22, 2024 16:50
@shorowit shorowit merged commit d3686ba into latest-os-hpxml Oct 22, 2024
@shorowit shorowit deleted the cfis_oa_control branch October 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant