ANSI 301-2022: shared water heaters, recirc pumps #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf4787bc15 Merge pull request #1649 from NREL/shared-wh-losses 679383d4cb One more minor clarification [ci skip] f3a4cee492 Just noticed that 301-2022 is now available on the ICC website. [ci skip] 7a5dd70fbf Update the docs. 88f320c9a0 Add validation test for shared recirc. 78f83a8111 Update the changelog. a25f2c951b Remove build measure default, update descriptions. 5c4727d211 Merge branch 'master' into shared-wh-losses 02f6489ad2 Revert recirc pump min beds change. 0a7235f7aa Revert "Updates for allowing 0 bedroom units in a building." 4114a8b4b7 Updates for allowing 0 bedroom units in a building. a3327b343d Update changelog and docs. 4ae4ede977 Update the docs. 779cd2f771 Update tasks and sample files for new recirc beds served. 27c4dd186e Update translator to use recirc bedrooms served. 3937fafedb Update and fix remaining defaults and validation tests. 493e062c88 Merge branch 'master' into shared-wh-losses 47f63d8158 Update and fix some unit tests. 862d2440b2 Update the docs. a4695b8f14 Update tasks and sample files for new wh beds served. 9f7f97e314 Update translator to use wh bedrooms served. 10b31c009f Replace wh units served argument with bedrooms served. git-subtree-dir: hpxml-measures git-subtree-split: bf4787bc154b4454b114328db0b1d5ade8e20d35
da6c0005bf Merge pull request #1661 from NREL/fix-footnotes 831a8fb04b Merge pull request #1673 from NREL/docs_footnote_check 32cc8f9a6d Merge branch 'docs_footnote_check' of https://github.com/NREL/OpenStudio-HPXML into fix-footnotes 3b071d134b Re-enable all tests. 88bd913d9a Check for number of footnote references not equal to number of footnotes. d323c56c7c Remove unneeded line [ci skip] 9b6a8c794e Update the changelog. 183b2f91b1 Merge branch 'master' into fix-footnotes d8003c7369 Merge pull request #1672 from NREL/floor_or_ceiling_handling 24b54c9dcc Merge branch 'master' of https://github.com/NREL/OpenStudio-HPXML into floor_or_ceiling_handling ddd49515f3 If `Floor/FloorOrCeiling` is known to be wrong, issue a warning and override the user input to avoid possible errors or incorrect results. 0b71f83ab4 Merge pull request #1671 from NREL/slab_bugfix 41c2694415 Fixes possible EnergyPlus error when a `Slab` representing a crawlspace dirt floor has perimeter or under slab insulation. Also adds a warning if a slab exposed perimeter is large compared to its area. 51be89b814 Merge pull request #1669 from NREL/hpxml_version 12cd2e95ad Add HPXML Version to the `run_simulation.rb --version` results. 4d04dc33b4 Latest results. 488a02c6bf Apply shared losses for hpwh and combi. 8ca642be74 Add sample file for shared hpwh. 36117e6da7 Remove extra note from combi with tankless. 151f7fbf5d Merge branch 'master' into fix-footnotes c213c1efef Merge pull request #1667 from NREL/mj_comb_inf_vent d8a1d510ac Latest results. d1bbcf1658 Update tests. 9299a68281 Update combined infiltration/ventilation design load equation to better align with MJ8. 02ef8a30ee Merge pull request #1666 from NREL/bump_add_to_project 596df32428 Attempt to address GHA warnings. 631308e07c Merge pull request #1665 from NREL/hvac_sizing_globals 0af1f94dd0 Remove final HVAC sizing globals. 8f1184884f Merge pull request #1662 from NREL/multiple_design_conditions bd9ad16fb8 Add PRs to project too 90e17b57a7 Revert remark in make bat file. [ci skip] 6da4303638 Add warning if there are multiple design conditions. e164e699b4 Try echoing everything in make bat. 1637a73f9d Fix some footnotes in water heater sections. git-subtree-dir: hpxml-measures git-subtree-split: da6c0005bf2147731f42e4c0557ed8b4a03e1bb4
… Add new shared HPWH test file.
shorowit
commented
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
[description here]
Checklist
PR Author: Check these when they're done. Not all may apply.
strikethroughand check any that do not apply.PR Reviewer: Verify each has been completed.
openstudio tasks.rb update_measureshas been run