Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine ERI output files #714

Merged
merged 3 commits into from
Feb 19, 2024
Merged

Combine ERI output files #714

merged 3 commits into from
Feb 19, 2024

Conversation

shorowit
Copy link
Collaborator

@shorowit shorowit commented Feb 9, 2024

Pull Request Description

Breaking change: Combines ERI_Results.csv and ERI_Worksheet.csv into a single ERI_Results.csv that better reflects the current ERI calculation components; additional fields (e.g., PEfrac) added and a few renamed/removed. Adds documentation for all fields.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

…lts.csv that better reflects the current ERI calculation components; additional fields (e.g., PEfrac) added and a few renamed/removed. Adds documentation for all fields.
@shorowit shorowit self-assigned this Feb 9, 2024
@shorowit shorowit merged commit a7a21c7 into latest-os-hpxml Feb 19, 2024
@shorowit shorowit deleted the combine_eri_csvs branch February 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant