Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ANSI 301-2022 Envelope #712

Merged
merged 21 commits into from
Mar 28, 2024
Merged

ANSI 301-2022 Envelope #712

merged 21 commits into from
Mar 28, 2024

Conversation

yzhou601
Copy link
Collaborator

@yzhou601 yzhou601 commented Jan 29, 2024 •
edited
Loading

Pull Request Description

  • PDS03: Different U-factors for walls adjacent to MF spaces, see Table 4.2.2(1)

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@yzhou601
Squashed 'hpxml-measures/' changes from 48a1aa5b65..03de5fc4ce
5155672 
03de5fc4ce Adds function for surfaces adjacent to common spaces

git-subtree-dir: hpxml-measures
git-subtree-split: 03de5fc4ce3fb247a1175cf1856cc8068a955c51
@yzhou601
Merge commit '51556726e484be3f2439bdeec2cf64436a3326d9' into ansi_301…
506a5f9 
…_2022_envelope
@yzhou601
first cut
1263719
@yzhou601 yzhou601 self-assigned this Jan 29, 2024
@yzhou601 yzhou601 changed the base branch from master to ansi_301_2022 January 29, 2024 21:14
yzhou601 and others added 10 commits January 29, 2024 14:27
@yzhou601
fix syntax
44481e7
@yzhou601
Squashed 'hpxml-measures/' changes from 03de5fc4ce..2fa679084e
be8f8cc 
2fa679084e simplify

git-subtree-dir: hpxml-measures
git-subtree-split: 2fa679084e8cb80fe3fbe147f473ec12d30ad230
@yzhou601
Merge commit 'be8f8cc85cf1f1d41646bcbdec85b8f07ee9ad22' into ansi_301…
f569bbd 
…_2022_envelope
@yzhou601
Squashed 'hpxml-measures/' changes from 2fa679084e..e70438fc24
fb57f1e 
e70438fc24 fix syntax

git-subtree-dir: hpxml-measures
git-subtree-split: e70438fc24cd1a6242479b10c0ffbc90f75a1317
@yzhou601
Merge commit 'fb57f1e4257a0c6d2479207ee871bb8b136f24bf' into ansi_301…
edb2b9f 
…_2022_envelope
@yzhou601
fix the hpxml connection
0042cc5
Latest results.
819ba33
@yzhou601
correct version condition
786947a
@yzhou601
unit test for common wall u factor change
d886618
@yzhou601
Merge branch 'ansi_301_2022_envelope' of https://github.com/NREL/Open…
0d8a96d 
…Studio-ERI into ansi_301_2022_envelope
Base automatically changed from ansi_301_2022 to latest-os-hpxml February 8, 2024 01:46
@yzhou601 yzhou601 force-pushed the ansi_301_2022_envelope branch from 894a120 to 5cd5596 Compare March 25, 2024 21:24
yzhou601
yzhou601 commented Mar 27, 2024
View reviewed changes
tasks.rb Show resolved Hide resolved
rulesets/resources/301ruleset.rb Show resolved Hide resolved
@shorowit shorowit marked this pull request as ready for review March 28, 2024 15:45
shorowit
shorowit approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work @yzhou601.

@shorowit shorowit merged commit e23f778 into latest-os-hpxml Mar 28, 2024
9 checks passed
@shorowit shorowit deleted the ansi_301_2022_envelope branch March 28, 2024 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shorowit shorowit shorowit approved these changes

Assignees

@yzhou601 yzhou601

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yzhou601 @shorowit