Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANSI 301-2022: load profile schedules #710

Merged
merged 23 commits into from
Feb 7, 2024

Conversation

joseph-robertson
Copy link
Collaborator

@joseph-robertson joseph-robertson commented Jan 26, 2024

Pull Request Description

Add tests for ANSI 301 schedules.

Checklist

PR Author: Check these when they're done. Not all may apply. strikethrough and check any that do not apply.

PR Reviewer: Verify each has been completed.

  • OS-HPXML git subtree has been pulled
  • 301/ES rulesets and unit tests have been updated
  • 301validator.xml has been updated (reference EPvalidator.xml)
  • Workflow tests have been updated
  • Documentation has been updated
  • Changelog has been updated
  • openstudio tasks.rb update_measures has been run
  • No unexpected regression test changes on CI

@joseph-robertson joseph-robertson self-assigned this Jan 26, 2024
@joseph-robertson
Copy link
Collaborator Author

Are there any additional components that should be assigned constant monthly multipliers?
Are there any changes/updates that need to be made to the OS-ERI documentation?

@joseph-robertson joseph-robertson marked this pull request as ready for review February 1, 2024 15:23
@joseph-robertson joseph-robertson requested review from shorowit and removed request for shorowit February 1, 2024 15:24
@joseph-robertson
Copy link
Collaborator Author

Reminder to add schedule tests for the rest of the ANSI 301 schedules (recirc pump, lighting, etc).

Copy link
Collaborator

@shorowit shorowit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just two minor things.

rulesets/tests/test_occupancy.rb Outdated Show resolved Hide resolved
rulesets/tests/test_appliances.rb Show resolved Hide resolved
@shorowit shorowit merged commit 35d0c3a into ansi_301_2022 Feb 7, 2024
@shorowit shorowit deleted the ansi_301_2022_lighting_appl branch February 7, 2024 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants