Merge branch 'ansi_301_2022' into ansi_301_2022_lighting_appl

NREL · Jan 31, 2024 · 900184c · 900184c
2 parents 582722f + 4d86a28
commit 900184c
Show file tree

Hide file tree

Showing 47 changed files with 159,000 additions and 158,948 deletions.
diff --git a/.github/workflows/config.yml b/.github/workflows/config.yml
@@ -13,7 +13,7 @@ jobs:
     container:
       image: docker://nrel/openstudio:3.7.0
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
@@ -38,7 +38,7 @@ jobs:
           bundle exec rake test_rulesets
 
       - name: Store code coverage
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: coverage
           name: coverage
@@ -49,7 +49,7 @@ jobs:
           make html SPHINXOPTS="-W --keep-going -n"
 
       - name: Save Docs
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           name: documentation
           path: docs/_build/html/
@@ -59,7 +59,7 @@ jobs:
     container:
       image: docker://nrel/openstudio:3.7.0
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
@@ -72,7 +72,7 @@ jobs:
           bundle exec rake test_sample_files1
 
       - name: Store results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/test_results
           name: test_results_sample_files1
@@ -82,7 +82,7 @@ jobs:
     container:
       image: docker://nrel/openstudio:3.7.0
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
@@ -95,7 +95,7 @@ jobs:
           bundle exec rake test_sample_files2
 
       - name: Store results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/test_results
           name: test_results_sample_files2
@@ -105,7 +105,7 @@ jobs:
     container:
       image: docker://nrel/openstudio:3.7.0
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
@@ -118,7 +118,7 @@ jobs:
           bundle exec rake test_real_homes
 
       - name: Store results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/test_results
           name: test_results_real_homes
@@ -128,7 +128,7 @@ jobs:
     container:
       image: docker://nrel/openstudio:3.7.0
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
@@ -141,15 +141,15 @@ jobs:
           bundle exec rake test_other
 
       - name: Store results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/test_results
           name: test_results_other
 
   run-windows-tests:
     runs-on: windows-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
       - name: Install software and run test
@@ -161,59 +161,47 @@ jobs:
           tar -xzf Windows.tar.gz
           & .\OpenStudio-${env:OS_VERSION}+${env:OS_SHA}-Windows\bin\openstudio.exe workflow\energy_rating_index.rb -x workflow\sample_files\base.xml --hourly ALL --add-component-loads
 
+  merge-results:
+    runs-on: ubuntu-latest
+    needs: [run-sample-files1-tests, run-sample-files2-tests, run-real-home-tests, run-other-tests]
+    steps:
+      - name: Merge Artifacts
+        uses: actions/upload-artifact/merge@v4
+        with:
+          name: results
+          pattern: test_results_*
+          delete-merged: true
+
   compare-results:
     if: github.event_name == 'pull_request'
     runs-on: ubuntu-latest
-    needs: [run-sample-files1-tests, run-sample-files2-tests, run-real-home-tests, run-other-tests]
+    needs: merge-results
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.base.sha }}
 
       - name: Store base results
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/base_results
           name: base_results
 
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.event.pull_request.head.sha }}
 
       - name: Download base results
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          path: |
-            base_results
+          path: base_results
           name: base_results
 
-      - name: Download Sample Files 1 feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_sample_files1
-
-      - name: Download Sample Files 2 feature results
-        uses: actions/download-artifact@v3
+      - name: Download feature results
+        uses: actions/download-artifact@v4
         with:
-          path: |
-            results
-          name: test_results_sample_files2
-
-      - name: Download Real Home feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_real_homes
-
-      - name: Download Other feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_other
+          path: results
+          name: results
 
       - name: Compare results
         run: |
@@ -230,46 +218,24 @@ jobs:
           python hpxml-measures/workflow/tests/compare.py -a visualize
 
       - name: Store comparisons
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
           path: workflow/tests/comparisons
           name: comparisons
 
   update-results:
     runs-on: ubuntu-latest
-    needs: [run-sample-files1-tests, run-sample-files2-tests, run-real-home-tests, run-other-tests]
+    needs: merge-results
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           ref: ${{ github.head_ref }}
 
-      - name: Download Sample Files 1 feature results
-        uses: actions/download-artifact@v3
+      - name: Download feature results
+        uses: actions/download-artifact@v4
         with:
-          path: |
-            results
-          name: test_results_sample_files1
-
-      - name: Download Sample Files 2 feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_sample_files2
-
-      - name: Download Real Home feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_real_homes
-
-      - name: Download Other feature results
-        uses: actions/download-artifact@v3
-        with:
-          path: |
-            results
-          name: test_results_other
+          path: results
+          name: results
 
       - name: Commit latest results
         shell: bash        

diff --git a/Changelog.md b/Changelog.md
@@ -10,6 +10,8 @@ __New Features__
 - Allows `Roof/RadiantBarrier` to be omitted; defaults to false.
 - Adds more error-checking for inappropriate inputs (e.g., HVAC SHR=0 or clothes washer IMEF=0).
 - Allows `FractionDuctArea` as alternative to `DuctSurfaceArea`
+- Clarifies that Capacity=-1 can be used to autosize HVAC equipment for research purposes or to run tests.
+  - It should *not* be used for a real home; a warning will be issued when it's used.
 
 __Bugfixes__
 - Fixes possible 301ruleset.rb error due to floating point arithmetic.