Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test, tweaks, and and fix for irregular waves #54

Merged
merged 5 commits into from
Feb 1, 2024
Merged

Test, tweaks, and and fix for irregular waves #54

merged 5 commits into from
Feb 1, 2024

Conversation

tridelat
Copy link
Collaborator

@tridelat tridelat commented Jan 19, 2024 •
edited
Loading

In this PR:

  • Fixed typo for excitation force convolution integral
  • Added test with comparison with reference data for irregular waves
  • Add option to use normalizing factor for JONSWAP spectrum (false by default)
  • Attach irregular wave parameters directly to irregular waves class (avoir repetition)
  • Expose min, max, and number of frequencies of spectrum as new parameters

@tridelat tridelat requested a review from dav-og January 19, 2024 12:06
@tridelat tridelat changed the title Test and fix for irregular waves Test, tweaks, and and fix for irregular waves Jan 23, 2024
dav-og
dav-og approved these changes Jan 31, 2024
View reviewed changes
Copy link
Collaborator

@dav-og dav-og left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work Tristan! 👍

All tests passing. Default nfrequencies value we discussed seems to already be = 0

image

@tridelat tridelat merged commit 1bf29b7 into NREL:main Feb 1, 2024
@tridelat tridelat deleted the tridelat/ex_fix branch February 1, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dav-og dav-og dav-og approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tridelat @dav-og