Separate Infiltration from Natural Ventilation Flows for AirflowNetwork #8689

lgu1234 · 2021-04-01T13:23:58Z

Pull request overview

Separate the following output variables from infiltration to both Infiltration and Ventilation:

AFN Zone Infiltration Volume AirflowNetworkZnRpt(i).InfilVolume
AFN Zone Infiltration Mass AirflowNetworkZnRpt(i).InfilMass
AFN Zone Infiltration Air Change Rate AirflowNetworkZnRpt(i).InfilAirChangeRate

Add 3 new output variables:

AFN Zone Ventilation Volume AirflowNetworkZnRpt(i).VentilVolume
AFN Zone Ventilation Mass AirflowNetworkZnRpt(i).VentilMass
AFN Zone Ventilation Air Change Rate AirflowNetworkZnRpt(i).VentilAirChangeRate

Fixes #8716 Corrects AFN infiltration in the Outdoor Air Details Report.

Add AFN Zone Ventilation output variables to testfiles as appropriate (has openings and ahs AFN Zone Infiltration outputs already).

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

[X ] Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
[ X] Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
[ X] Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
[X ] Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
[X ] If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If changes fix a defect, the fix should be demonstrated in plots and descriptions
If any defect files are updated to a more recent version, upload new versions here or on DevSupport
If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
If structural output changes, add to output rules file and add OutputChange label
If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

…al-ventilation

lgu1234 · 2021-04-01T17:50:56Z

Outputs of infiltration from develop

Outputs of sum of infiltration and ventilation from branch

Outputs of ventilation from branch

Outputs of infiltration from branch

lgu1234 · 2021-04-01T17:39:29Z

doc/input-output-reference/src/overview/group-airflow-network.tex

+\item
+  HVAC,Sum,AFN Zone Ventilation Mass {[}kg{]}
+\item
+  HVAC,Average,AFN Zone Ventilation Air Change Rate {[}ach{]}


Add 3 new output variables for natural ventilation flows

lgu1234 · 2021-04-01T17:40:15Z

src/EnergyPlus/AirflowNetwork/include/AirflowNetwork/Elements.hpp

@@ -1493,6 +1493,8 @@ namespace AirflowNetwork {
        Real64 TotalLat;
        Real64 SumMCp;
        Real64 SumMCpT;
+        Real64 SumMVCp;
+        Real64 SumMVCpT;


Add 2 more variables to store ventilation values.

lgu1234 · 2021-04-01T17:40:39Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+                                state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).VentilAirChangeRate,
+                                "System",
+                                "Average",
+                                Zone(i).Name);


Add output variables for report.

I added AFN Zone Ventilation output variables to pertinent files (ones with AFN Zone Infiltration variables that also have openings).

lgu1234 · 2021-04-01T17:41:00Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

@@ -9464,6 +9485,9 @@ namespace AirflowNetworkBalanceManager {
            e.InfilVolume = 0.0;
            e.InfilMass = 0.0;
            e.InfilAirChangeRate = 0.0;
+            e.VentilVolume = 0.0;
+            e.VentilMass = 0.0;
+            e.VentilAirChangeRate = 0.0;


Initialization.

lgu1234 · 2021-04-01T17:41:24Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+            state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).VentilAirChangeRate =
+                state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).VentilVolume / (TimeStepSys * Zone(i).Volume);
+            state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).VentilMass =
+                (state.dataAirflowNetworkBalanceManager->exchangeData(i).SumMVCp / CpAir) * ReportingConstant;


Calculate outputs for natural ventilation.

lgu1234 · 2021-04-01T17:41:57Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+                            state.dataAirflowNetwork->AirflowNetworkLinkSimu(i).FLOW2 * CpAir;
+                        state.dataAirflowNetworkBalanceManager->exchangeData(ZN1).SumMVCpT +=
+                            state.dataAirflowNetwork->AirflowNetworkLinkSimu(i).FLOW2 * CpAir * Tamb;
+                    }


Separate infiltration and natural ventilation.

lgu1234 · 2021-04-01T17:43:07Z

src/EnergyPlus/CrossVentMgr.cc

                        state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMMCp;
            MCpT_Total = state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMCpT +
+                         state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMVCpT +


Add infiltration and ventilation impact together. A single variables was used previously.

lgu1234 · 2021-04-01T17:43:38Z

src/EnergyPlus/ZoneTempPredictorCorrector.cc

+                        state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMVCpT -
+                        (state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMCp +
+                         state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMVCp) *
+                            state.dataHeatBalFanSys->MAT(ZoneNum);


Include infiltration and ventilation together.

…ate-AFN-infiltration-from-natural-ventilation

mjwitte

@lgu1234 A few comments below. I also added some change to feed into the OA Details report. But something is off in that report that I still need to fix here.

mjwitte · 2021-04-08T22:03:29Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

@@ -12745,8 +12809,10 @@ namespace AirflowNetworkBalanceManager {
        CpAir = PsyCpAirFnW(state.dataHeatBalFanSys->ZoneAirHumRat(ZoneNum));
        RhoAir = PsyRhoAirFnPbTdbW(
            state, state.dataEnvrn->OutBaroPress, state.dataHeatBalFanSys->MAT(ZoneNum), state.dataHeatBalFanSys->ZoneAirHumRat(ZoneNum));
-        InfilVolume =
-            (state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMCp / CpAir / RhoAir) * TimeStepSys * DataGlobalConstants::SecInHour;
+        InfilVolume = ((state.dataAirflowNetworkBalanceManager->exchangeData(ZoneNum).SumMCp +


To avoid confusion down the road, I would rename this function from GetZoneInfilAirChangeRate to something like GetZoneOutdoorAirChangeRate or at least add comments here to explain why both infiltration and ventilation flows are summed here.

Done. Change the function name.

mjwitte · 2021-04-08T22:04:23Z

src/EnergyPlus/AirflowNetworkBalanceManager.hh

@@ -78,6 +78,7 @@ namespace AirflowNetworkBalanceManager {
        Real64 VentilHeatGain;     // Heat Loss {W} due to ventilation
        Real64 VentilVolume;       // Volume of Air {m3} due to ventilation
        Real64 VentilMass;         // Mass of Air {kg} due to ventilation
+        Real64 VentilAirChangeRate; // Infiltration air change rate {ach}


In the comment: Infiltration --> Ventilation

…ate-AFN-infiltration-from-natural-ventilation

…' of https://github.com/NREL/EnergyPlus into 8475-Separate-AFN-infiltration-from-natural-ventilation

mjwitte · 2021-04-12T21:59:34Z

@lgu1234 I made a few more tweaks to this. For an opening, when it is closed, where does that airflow get recorded? Is that infiltration or ventilation?

lgu1234 · 2021-04-12T23:57:18Z

@mjwitte I assume airflow gets recorded in ventilation, when openings are closed.

…ate-AFN-infiltration-from-natural-ventilation

…bles

mjwitte

@lgu1234 After CI completes another round, I think this will be ready to merge. Feel free to review my changes if you want.

mjwitte · 2021-04-13T22:08:06Z

src/EnergyPlus/OutputReportTabular.cc

+                PreDefTableEntry(state,
+                                 state.dataOutRptPredefined->pdchOaTaBzInfil,
+                                 Zone(iZone).Name,
+                                 ZonePreDefRep(iZone).InfilVolTotalStdDen + ZonePreDefRep(iZone).AFNInfilVolTotalStdDen);


This change is the source of many table diffs in the AFN files. Previously AFN infiltration was omitted from the Infiltration columns in the Outdoor Air Details report. I should probably post an issue about that.

mjwitte · 2021-04-13T22:09:16Z

src/EnergyPlus/AirflowNetworkBalanceManager.cc

+                                state.dataAirflowNetworkBalanceManager->AirflowNetworkZnRpt(i).VentilAirChangeRate,
+                                "System",
+                                "Average",
+                                Zone(i).Name);


I added AFN Zone Ventilation output variables to pertinent files (ones with AFN Zone Infiltration variables that also have openings).

lgu1234 · 2021-04-14T13:03:50Z

@mjwitte I reviewed your changes. They are OK with me. Thanks.

…ate-AFN-infiltration-from-natural-ventilation

Upload a fix

af69ecb

lgu1234 added the Defect Includes code to repair a defect in EnergyPlus label Apr 1, 2021

lgu1234 added 2 commits April 1, 2021 10:07

Merge branch 'develop' into 8475-Separate-AFN-infiltration-from-natur…

3f8dcdd

…al-ventilation

Solve merge conflict

8689baa

lgu1234 commented Apr 1, 2021

View reviewed changes

mjwitte added 2 commits April 8, 2021 15:59

Merge remote-tracking branch 'remotes/origin/develop' into 8475-Separ…

73ab5d1

…ate-AFN-infiltration-from-natural-ventilation

OA Details - separate AFN infil and vent

eadca0f

mjwitte reviewed Apr 9, 2021

View reviewed changes

lgu1234 and others added 5 commits April 9, 2021 09:39

Address comments

e264b7a

OA Details - fix AFN infil and vent

a1ed191

Merge remote-tracking branch 'remotes/origin/develop' into 8475-Separ…

d4d6f3e

…ate-AFN-infiltration-from-natural-ventilation

Merge branch '8475-Separate-AFN-infiltration-from-natural-ventilation…

ef7cf5f

…' of https://github.com/NREL/EnergyPlus into 8475-Separate-AFN-infiltration-from-natural-ventilation

Separate AFN infiltration and ventilation - attempt to save a few cycles

b693d92

OA Details - some cleanup

bb5cacd

mjwitte added 2 commits April 13, 2021 15:43

Merge remote-tracking branch 'remotes/origin/develop' into 8475-Separ…

4d33cfa

…ate-AFN-infiltration-from-natural-ventilation

Separate AFN infiltration and ventilation - add AFN vent output varia…

b979ed6

…bles

mjwitte approved these changes Apr 13, 2021

View reviewed changes

mjwitte added 2 commits April 13, 2021 17:49

Fix formatting

e1b6ea0

More formatting

18b4bd0

mjwitte added 2 commits April 14, 2021 14:37

Merge remote-tracking branch 'remotes/origin/develop' into 8475-Separ…

9871588

…ate-AFN-infiltration-from-natural-ventilation

Merge remote-tracking branch 'remotes/origin/develop' into 8475-Separ…

57948ab

…ate-AFN-infiltration-from-natural-ventilation

mjwitte merged commit 4a4bce0 into develop Apr 15, 2021

mjwitte deleted the 8475-Separate-AFN-infiltration-from-natural-ventilation branch April 15, 2021 19:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Separate Infiltration from Natural Ventilation Flows for AirflowNetwork #8689

Separate Infiltration from Natural Ventilation Flows for AirflowNetwork #8689

lgu1234 commented Apr 1, 2021 •

edited by mjwitte

Loading

lgu1234 commented Apr 1, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

mjwitte Apr 13, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

lgu1234 Apr 1, 2021

mjwitte left a comment

mjwitte Apr 8, 2021

lgu1234 Apr 9, 2021

mjwitte Apr 8, 2021

lgu1234 Apr 9, 2021

mjwitte commented Apr 12, 2021

lgu1234 commented Apr 12, 2021

mjwitte left a comment

mjwitte Apr 13, 2021

mjwitte Apr 13, 2021

lgu1234 commented Apr 14, 2021

Separate Infiltration from Natural Ventilation Flows for AirflowNetwork #8689

Separate Infiltration from Natural Ventilation Flows for AirflowNetwork #8689

Conversation

lgu1234 commented Apr 1, 2021 • edited by mjwitte Loading

Pull request overview

Pull Request Author

Reviewer

lgu1234 commented Apr 1, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mjwitte commented Apr 12, 2021

lgu1234 commented Apr 12, 2021

mjwitte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lgu1234 commented Apr 14, 2021

lgu1234 commented Apr 1, 2021 •

edited by mjwitte

Loading