Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the name of the AirflowNetwork group #8434

Merged
merged 2 commits into from
Jan 5, 2021

Conversation

jasondegraw
Copy link
Member

@jasondegraw jasondegraw commented Dec 21, 2020

Pull request overview

Since we're keeping around groups after all, this PR changes the name of the group that contained all of the AirflowNetwork objects to be somewhat more accurate. It isn't really a traditional defect, but that's the thing that is closest. I do not know if the DoNotPublish label should be applied as well.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@jasondegraw jasondegraw added Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Dec 21, 2020
@jasondegraw jasondegraw added this to the EnergyPlus 9.5.0 IOFreeze milestone Dec 21, 2020
@Myoldmopar
Copy link
Member

Pulled develop in for clean CI results. Anyone have any possible issue with changing this group name? I don't have any issue with it.

@Myoldmopar
Copy link
Member

Custom check results are expected until license year PR goes in. Windows didn't respond because the CI machine went down. No one else commented about the group name. This is good to go in, thanks @jasondegraw

@Myoldmopar Myoldmopar merged commit d48c555 into develop Jan 5, 2021
@Myoldmopar Myoldmopar deleted the change-afn-group-name branch January 5, 2021 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants