-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global state refactor continued #8414
Conversation
…functions to constexpr
…y a clear_state issue
Only CI issues are now the spurious diffs in the shading file and the integration coverage dipping below the limit. This looks to be ready to go. I will hold on merging momentarily while I do final review on the air wall PR and possibly drop that in first. But as long as that one is good to go then these will both drop in sometime today. |
Alright got develop pulled in, everything is looking great here locally. Enabled the unit test that was failing as well. If CI is clean, this beast can drop in. |
OK, this looks good to go in. This is a big set of changes, and there will be a follow-on branch that addresses the state-as-an-argument issue. If you are having lots of conflicts, just let me know and I'll pull your branch and help get them addressed. I'll be dropping this in now... Thanks @mitchute and @jmythms for the big effort here. Among all the actual global "variables" that were addressed, another 400 or so |
Pull request overview
This is a big set of changes, but I think it will be totally clean on CI.