-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Output Variables to Ideal Air loads #8302
Changes from 36 commits
861cfef
908ab51
6b7b538
5acf86f
0bc4fdf
a5b0833
14dbd0d
7bf3209
6b73be5
a33d794
e5f0e2a
89a70d3
18e8fb9
279aa5c
747afea
3cd3110
bbe882a
2ef45da
754e98c
cbdb675
e487697
4972b6f
0fc065b
2461195
120fac1
2dac64b
56c86eb
227bdd2
71755c5
6d6654b
660dacb
fd33e3e
7fbaa76
f67fbc8
ec0199d
bebe31c
863baf5
e4ade3a
3cfe237
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Large diffs are not rendered by default.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -190,8 +190,6 @@ namespace PurchasedAirManager { | |
Real64 SupplyAirMassFlowRate; // Supply air mass flow rate [kg/s] | ||
Real64 SupplyAirVolFlowRateStdRho; // supply air volume flow using standard density [m3/s] | ||
// Intermediate results | ||
Real64 FinalMixedAirTemp; // Dry-bulb temperature of the mixed air, saved for system ventilation load reporting [C] | ||
Real64 FinalMixedAirHumRat; // Humidity ratio of the mixed air, saved for system ventilation load reporting [kgWater/kgDryAir] | ||
Real64 HtRecSenOutput; // Sensible heating/cooling rate from heat recovery (<0 means cooling) [W] | ||
Real64 HtRecLatOutput; // Latent heating/cooling rate from heat recovery (<0 means cooling or dehumidfying) [W] | ||
Real64 OASenOutput; // Outdoor air sensible output relative to zone conditions [W], <0 means OA is cooler than zone air | ||
|
@@ -262,6 +260,10 @@ namespace PurchasedAirManager { | |
Real64 TimeHtRecActive; // Time heat reocovery is active [hrs] | ||
int ZonePtr; // pointer to a zone served by an Ideal load air system | ||
int HVACSizingIndex; // index of a HVAC Sizing object for an Ideal load air system | ||
Real64 SupplyTemp; // Supply inlet to zone dry bulb temperature [C] | ||
Real64 SupplyHumRat; // Supply inlet to zone humidity ratio [kgWater/kgDryAir] | ||
Real64 MixedAirTemp; // Mixed air dry bulb temperature [C] | ||
Real64 MixedAirHumRat; // Mixed air humidity ratio [kgWater/kgDryAir] | ||
|
||
// Default Constructor | ||
ZonePurchasedAir() | ||
|
@@ -274,8 +276,7 @@ namespace PurchasedAirManager { | |
EMSValueMassFlowRate(0.0), EMSOverrideOAMdotOn(false), EMSValueOAMassFlowRate(0.0), | ||
EMSOverrideSupplyTempOn(false), EMSValueSupplyTemp(0.0), EMSOverrideSupplyHumRatOn(false), | ||
EMSValueSupplyHumRat(0.0), MinOAMassFlowRate(0.0), | ||
OutdoorAirMassFlowRate(0.0), OutdoorAirVolFlowRateStdRho(0.0), SupplyAirMassFlowRate(0.0), SupplyAirVolFlowRateStdRho(0.0), | ||
FinalMixedAirTemp(0.0), FinalMixedAirHumRat(0.0), HtRecSenOutput(0.0), HtRecLatOutput(0.0), OASenOutput(0.0), OALatOutput(0.0), | ||
OutdoorAirMassFlowRate(0.0), OutdoorAirVolFlowRateStdRho(0.0), SupplyAirMassFlowRate(0.0), SupplyAirVolFlowRateStdRho(0.0), HtRecSenOutput(0.0), HtRecLatOutput(0.0), OASenOutput(0.0), OALatOutput(0.0), | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not sure why this line didn't wrap earlier. It's much longer than all the rest. Was Clang format used? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rraustad I just checked this, it was disabled in my IDE. Shall I do one more commit after reformatting? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @Myoldmopar is it worth another commit for Clang formatting the hh file? I don't see any other changes needed, but I haven't tested the example file yet. Unit tests run clean locally. |
||
SenOutputToZone(0.0), LatOutputToZone(0.0), SenCoilLoad(0.0), LatCoilLoad(0.0), OAFlowMaxCoolOutputError(0), | ||
OAFlowMaxHeatOutputError(0), SaturationOutputError(0), OAFlowMaxCoolOutputIndex(0), OAFlowMaxHeatOutputIndex(0), | ||
SaturationOutputIndex(0), AvailStatus(0), CoolErrIndex(0), HeatErrIndex(0), SenHeatEnergy(0.0), LatHeatEnergy(0.0), TotHeatEnergy(0.0), | ||
|
@@ -286,8 +287,8 @@ namespace PurchasedAirManager { | |
SenHeatRate(0.0), LatHeatRate(0.0), TotHeatRate(0.0), SenCoolRate(0.0), LatCoolRate(0.0), TotCoolRate(0.0), ZoneSenHeatRate(0.0), | ||
ZoneLatHeatRate(0.0), ZoneTotHeatRate(0.0), ZoneSenCoolRate(0.0), ZoneLatCoolRate(0.0), ZoneTotCoolRate(0.0), OASenHeatRate(0.0), | ||
OALatHeatRate(0.0), OATotHeatRate(0.0), OASenCoolRate(0.0), OALatCoolRate(0.0), OATotCoolRate(0.0), HtRecSenHeatRate(0.0), | ||
HtRecLatHeatRate(0.0), HtRecTotHeatRate(0.0), HtRecSenCoolRate(0.0), HtRecLatCoolRate(0.0), HtRecTotCoolRate(0.0), TimeEconoActive(0.0), | ||
TimeHtRecActive(0.0), ZonePtr(0), HVACSizingIndex(0) | ||
HtRecLatHeatRate(0.0), HtRecTotHeatRate(0.0), HtRecSenCoolRate(0.0), HtRecLatCoolRate(0.0), HtRecTotCoolRate(0.0), TimeEconoActive(0.0), | ||
TimeHtRecActive(0.0), ZonePtr(0), HVACSizingIndex(0), SupplyTemp(0.0), SupplyHumRat(0.0), MixedAirTemp(0.0), MixedAirHumRat(0.0) | ||
{ | ||
} | ||
}; | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -1930,6 +1930,16 @@ | |
|
||
Output:Variable,*,Zone Ideal Loads Heat Recovery Active Time,hourly; | ||
|
||
Output:Variable,*,Zone Ideal Loads Supply Air Temperature,hourly; | ||
|
||
Output:Variable,*,Zone Ideal Loads Supply Air Humidity Ratio,hourly; | ||
|
||
Output:Variable,*,Zone Ideal Loads Mixed Air Temperature,hourly; | ||
|
||
Output:Variable,*,Zone Ideal Loads Mixed Air Humidity Ratio,hourly; | ||
|
||
Output:Variable,*,System Node Mass Flow Rate,hourly; | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Now the results appear in the test file output. Should I change the reporting frequency to hourly? Also, the effects are better visible for an annual simulation. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, I would make the reporting frequency consistent - looks like everything else is hourly. |
||
Output:Variable,SPACE2-1 Ideal Loads Outdoor Air Inlet,System Node Standard Density Volume Flow Rate,hourly; | ||
|
||
Output:Variable,SPACE3-1 Ideal Loads Outdoor Air Inlet,System Node Standard Density Volume Flow Rate,hourly; | ||
|
@@ -1969,4 +1979,3 @@ | |
|
||
Output:Table:SummaryReports, | ||
AllSummary; !- Report 1 Name | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed them since I felt the new mixedairtemp and mixedairhumrat were doing the same thing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And it appears that
FinalMixedAirTemp
andFinalMixedAirHumRat
weren't being used anywhere, so find to replace them here.