Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unshaded inside reveal array bounds error and add reveal and sill to Fenestration_RefBldgSmallHotelNew2004_Chicago #10442

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

mjwitte
Copy link
Contributor

@mjwitte mjwitte commented Mar 18, 2024

Pull request overview

  • Fixes Window frame with inside reveal trips on array bounds error #10441
  • Add inside reveal and sill to some windows in Fenestration_RefBldgSmallHotelNew2004_Chicago.idf (initial commit should fail in debug mode). This should introduce some small diffs for this test file.
  • Move shaded construction assignment in CalcBeamSolarOnWinRevealSurface to avoid array bounds error if window has inside reveal and is unshaded.
  • Add unit test.
  • Clean up unrelated doc warnings.

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mjwitte mjwitte added the Defect Includes code to repair a defect in EnergyPlus label Mar 18, 2024
@mjwitte mjwitte added this to the EnergyPlus 24.1 milestone Mar 19, 2024
@mjwitte mjwitte marked this pull request as ready for review March 20, 2024 13:17
@mjwitte
Copy link
Contributor Author

mjwitte commented Mar 20, 2024

This is ready for final review.

  • Small diffs are expected in Fenestration_RefBldgSmallHotelNew2004_Chicago due to the addition of inside and outside reveal and sill properties to frame type "Wood-Divider-07-FrameAndDiv" which is used by several windows.
  • The new version of Fenestration_RefBldgSmallHotelNew2004_Chicago fails with an array bounds error with current develop debug build; runs to completion in debug build here.
  • Coverage results now show significant portions of CalcBeamSolarOnWinRevealSurface are now covered for integration and unit tests.
  • Some unrelated doc warnings were also cleaned up.

@mjwitte mjwitte mentioned this pull request Mar 21, 2024
3 tasks
@Myoldmopar
Copy link
Member

Thanks @mjwitte, I'll let CI confirm but this should be able to drop in directly.

@Myoldmopar
Copy link
Member

Exactly what you were expecting to see, with cleanups and bonus extra test coverage and doc fixes. This is great, thanks @mjwitte!

@Myoldmopar Myoldmopar merged commit c3ab25e into develop Mar 25, 2024
15 checks passed
@Myoldmopar Myoldmopar deleted the insideReveal branch March 25, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Window frame with inside reveal trips on array bounds error
8 participants