Variable speed fan powered induction boxes #10368

lymereJ · 2024-01-13T00:41:10Z

Pull request overview

Implement variable speed fan powered induction boxes. Follows the approach of #10336 and supersedes it.

Simulation results for the different controls are shown here (see the .ipnyb file).

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
If any diffs are expected, author must demonstrate they are justified using plots and descriptions
If structural output changes, add to output rules file and add OutputChange label
If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

nrel-bot-2 · 2024-02-29T00:13:54Z

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

…o `heatingOperatingMode` to be consistent with cooling.

lymereJ · 2024-03-08T22:21:48Z

src/EnergyPlus/Plant/PlantManager.cc

-
-        } else {
-            // fill PlantSizFac from data structure
-            //                    for (BranchNum = 1;
-            //                         BranchNum <= PlantLoop(LoopNum).LoopSide(LoopSideLocation::Supply).TotalBranches; ++BranchNum) {
-            //                        if (PlantLoop(LoopNum).LoopSide(LoopSideLocation::Supply).NodeNumIn ==
-            //                            PlantLoop(LoopNum).LoopSide(LoopSideLocation::Supply).Branch(BranchNum).NodeNumIn) {
-            //                            break;
-            //                        }
-            //                    }


lymereJ · 2024-03-08T22:22:23Z

doc/input-output-reference/CMakeLists.txt

+    ${PROJECT_SOURCE_DIR}/input-output-reference/media/VSFanStagedHeatControlDiag.png
+    ${PROJECT_SOURCE_DIR}/input-output-reference/media/SeriesVSFanModulatedHeatControlDiag.png
+    ${PROJECT_SOURCE_DIR}/input-output-reference/media/vav_parallel_fpb_trane_staged.png
+    ${PROJECT_SOURCE_DIR}/input-output-reference/media/vav_parallel_fpb_trane_modulated.png


Add new figures/pictures.

lymereJ · 2024-03-08T22:23:41Z

tst/EnergyPlus/unit/PoweredInductionUnits.unit.cc

@@ -1964,3 +1966,1069 @@ TEST_F(EnergyPlusFixture, PIU_InducedAir_Plenums)
    });
    EXPECT_TRUE(compare_err_stream(expectedError, true));
 }
+
+TEST_F(EnergyPlusFixture, VSParallelPIUStagedHeat)


New tests were added for both the VS series and parallel PIUs for each stage of the staged and modulated heating operations. A test was also added for the VS cooling operation of the series PIU.

lymereJ · 2024-03-14T18:42:24Z

src/EnergyPlus/PoweredInductionUnits.cc

+        if (thisPIU.fanControlType == FanCntrlType::VariableSpeedFan) {
+            // calculate fan speed ratio
+            Real64 fanFlowRatio(1.0);
+            if (thisPIU.MaxTotAirMassFlow > 0.0) {
+                fanFlowRatio = (thisPIU.PriAirMassFlow + thisPIU.SecAirMassFlow) / thisPIU.MaxTotAirMassFlow;
+            }
+            state.dataHVACFan->fanObjs[thisPIU.Fan_Index]->simulate(state, fanFlowRatio, _);
+        } else {
+            state.dataHVACFan->fanObjs[thisPIU.Fan_Index]->simulate(state, _, _);
+        }


This might seem redundant but it is setup this way to avoid regression diffs due to #10438.

Since your math looks correct, which fan output report changed in the existing example files? FYI, I just fixed a fan sizing issue in PIU in a forked repo.

Here's what I see in the EIO file for PlantLoopHeatPump_EIR_Large-Office-2-AWHP-DedHR-AuxBoiler-Pri-Sec-HW.idf when running it from this branch but also from develop:

Component Sizing Information, AirTerminal:SingleDuct:SeriesPIU:Reheat, CORE_BOTTOM PIUHEATING, Design Size Maximum Primary Air Flow Rate [m3/s], 4.18760 Component Sizing Information, Fan:SystemModel, CORE_BOTTOM PIUHEATING FAN, Design Size Design Maximum Air Flow Rate [m3/s], 4.51031

The file is intended to be run for Chicago but I'm running it for Golden, CO.

If you look at SystemAirFlowSizing.cc you will see that the TU fan sizes using FinalZoneSizing data while the TU sizes using TermUnitFinalZoneSizing. So the TU needs to set a flag to use the correct data for sizing a fan. This is what I set over in PoweredInductionUnits.cc to get fan sizing correct for:

SeriesPIU:

state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).SystemAirFlow = true; state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).AirVolFlow = state.dataPowerInductionUnits->PIU(PIUNum).MaxTotAirVolFlow;

Parallel PIU:

state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).SystemAirFlow = true; state.dataSize->ZoneEqSizing(state.dataSize->CurZoneEqNum).AirVolFlow = state.dataPowerInductionUnits->PIU(PIUNum).MaxSecAirVolFlow;

Thanks, I'll take a look at it. Is that okay if I include these changes in a dedicated PR for #10438? There's already a lot of changes (in my opinion) in this PR and the CI comes out relatively clean, at least with a manageable number of (expected) diffs.

Yes, OK to include this fan sizing change in #10438.

rraustad · 2024-03-15T02:55:19Z

Configuration reminder:

@lymereJ another good test for these changes to TU controls is to plot the air flow and outlet temperature versus the zone predicted load. Like these plots in the Eng. Ref. Probably want to also look at primary and secondary flow versus the expected performance.

lymereJ · 2024-03-19T22:11:04Z

@lymereJ another good test for these changes to TU controls is to plot the air flow and outlet temperature versus the zone predicted load. Like these plots in the Eng. Ref. Probably want to also look at primary and secondary flow versus the expected performance.

Because this requires lots of plots (which might need to get updated based on review comments), I thought that perhaps it would be best to host them somewhere else so I put them a separate repository, here (see the .ipnyb file).

lymereJ · 2024-03-19T22:12:31Z

The only diffs are AUD, RDD, and Table diffs and are due to the new outputs.

rraustad · 2024-03-20T00:42:21Z

Those ipnyb plots look pretty good. The controls are in good shape.

nrel-bot-3 · 2024-04-19T00:09:31Z

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

Myoldmopar · 2024-05-08T16:12:43Z

@lymereJ so this got conflicted with some of the other refactors. The GitHub web interface is offering to let me resolve them, so they aren't very complex, but I'm not able to see exactly what changed. Could you take a pass and see what needs to be done? I am assuming it is purely the fan hierarchy refactor that @amirroth contributed. Let me know if you need assistance.

lymereJ · 2024-05-08T17:39:36Z

Thanks for letting me know, I'll take a stab at it and try not to break things.

lymereJ · 2024-05-09T16:07:24Z

@Myoldmopar - Conflicts resolved!

nrel-bot · 2024-06-07T00:18:34Z

@lymereJ @Myoldmopar it has been 28 days since this pull request was last updated.

EnergyArchmage

I have studied the code, built locally, compared to contribution in #10336. Looks good. I really like how the control logic is collected into new routines and reused between series PIU and parallel PIU. Going to be a great improvement.

dareumnam · 2024-06-25T15:02:14Z

I pulled the develop branch and resolved the errors regarding compare_enums. The diffs are due to the new outputs, which are expected. All comments have been addressed and everything looks clean. I think this is ready to be merged. @Myoldmopar

Myoldmopar · 2024-06-25T16:54:54Z

Thanks @dareumnam, I concur. Everything looks happy. Merging this. Thanks @lymereJ

rraustad · 2024-08-18T00:12:37Z

src/EnergyPlus/PoweredInductionUnits.cc

+            if (SolFla == -1) {
+                ShowSevereError(state, "Iteration limit exceeded in calculating variable speed fan powered box cooling signal");
+                ShowContinueErrorTimeStamp(state, "");
+                ShowFatalError(state, format("Series PIU control failed for {}:{} ", thisPIU.UnitType, thisPIU.Name));


This is not good practice to fatal out on an iteration (or even SolFla ==2) error. It's better to write an error message, guess at a result, and proceed.

jmarrec · 2024-09-30T12:41:56Z

testfiles/5ZoneAirCooledConvCoef_VSFan.idf

+    VariableSpeed,
+    0.5,
+    Staged,
+    ,
+    ;


I'm super late to the party, but this is unfortunate this doesn't have the field comments, as grepping for "Heating Control Type" in the testfiles/ folder returns nothing. I was trying to find an example file to test this is new feature.

jmarrec · 2024-09-30T12:45:01Z

src/EnergyPlus/PoweredInductionUnits.cc

+                        ShowSevereError(state, format("Illegal Heating Control Type = {}", heating_control_type));
+                        ShowContinueError(state, format("Occurs in {} = {}", cCurrentModuleObject, thisPIU.Name));


Specifically, the thing I was trying to test was this error message.

The "Heating Control Type" field isn't marked required, because it's used only when "Fan Control Type" = VariableSpeed.

The error is less than informative in case you just forgot to fill it.

** Severe ** Illegal Heating Control Type = ** ~~~ ** Occurs in AirTerminal:SingleDuct:SeriesPIU:Reheat = SPACE1-1 VAV REHEAT ** Fatal ** GetPIUs: Errors found in getting input. Preceding conditions cause termination.

--- a/testfiles/5ZoneAirCooledConvCoef_VSFan.idf +++ b/testfiles/5ZoneAirCooledConvCoef_VSFan.idf @@ -2436,7 +2436,7 @@ 0.0001, !- Convergence Tolerance VariableSpeed, 0.5, - Modulated, + , , ;

Thanks for pointing it out, I'll address it today.

lymereJ added 7 commits November 27, 2023 12:12

Initial NFP.

eb01f8e

Fix typos.

a249b07

Merge branch 'develop' into variable_speed_piu

93f861e

Update figure. [decent_ci_skip]

56ac29f

Merge branch 'develop' into variable_speed_piu

ab1a6b4

Add VS parallel FPB based on VS Series FPB in #10336.

01f5ea9

Merge branch 'develop' into variable_speed_piu

cf6f6a4

lymereJ added NewFeature Includes code to add a new feature to EnergyPlus IDDChange Code changes impact the IDD file (cannot be merged after IO freeze) labels Jan 13, 2024

lymereJ added this to the EnergyPlus 24.2 IOFreeze milestone Jan 13, 2024

lymereJ added 4 commits January 13, 2024 09:17

Correct typos.

cf0b26a

Correct typos ct'd.

657b22a

Handle cases where we only have one type of terminal.

046e64a

Add heating logic for VS series PIU (from #10336), and fix reporting.

596b26f

Myoldmopar assigned lymereJ Jan 31, 2024

lymereJ added 7 commits March 5, 2024 10:16

Merge branch 'develop' into variable_speed_piu

453d4e3

Add adpated VS series PIU cooling from #10336.

fc272de

Merge branch 'develop' into variable_speed_piu

4572702

Add tests for VS parallel PIUs.

c021e6e

Add tests for VS parallel PIUs (heating).

0116bb0

Add test for VS series PIUs (cooling). Change heaterOperatingMode t…

4e600ce

…o `heatingOperatingMode` to be consistent with cooling.

Merge branch 'develop' into variable_speed_piu

5f817f4

lymereJ added the OutputChange Code changes output in such a way that it cannot be merged after IO freeze label Mar 8, 2024

lymereJ added 3 commits March 8, 2024 13:54

Update docs.

43efa58

Wrong spot for pictures.

10bcf84

Re-add pictures.

401fc92

lymereJ commented Mar 8, 2024

View reviewed changes

lymereJ commented Mar 14, 2024

View reviewed changes

lymereJ added 2 commits March 19, 2024 14:57

Clean up.

20aeef5

Merge branch 'develop' into variable_speed_piu

5db7f66

Update output reporting.

34ed14c

lymereJ marked this pull request as ready for review March 21, 2024 15:43

lymereJ requested a review from EnergyArchmage March 21, 2024 15:43

lymereJ added 3 commits May 8, 2024 11:00

Merge branch 'develop' into variable_speed_piu and address conflicts.

0b375be

Fix merging issues.

d2888b3

Merge branch 'develop' into variable_speed_piu

1672006

EnergyArchmage reviewed Jun 12, 2024

View reviewed changes

EnergyArchmage mentioned this pull request Jun 12, 2024

Variable Speed Fan series powered induction box #10336

Closed

20 tasks

dareumnam added 2 commits June 21, 2024 12:45

Merge remote-tracking branch 'origin/develop' into variable_speed_piu

8bbaeef

resolve errors

b420467

Myoldmopar merged commit 9eae3c1 into develop Jun 25, 2024
16 checks passed

Myoldmopar deleted the variable_speed_piu branch June 25, 2024 16:54

rraustad reviewed Aug 18, 2024

View reviewed changes

jmarrec reviewed Sep 30, 2024

View reviewed changes

lymereJ mentioned this pull request Sep 30, 2024

Variable speed PIUs: add example files fieldnames and revise error message #10776

Open

12 tasks

jmarrec mentioned this pull request Oct 2, 2024

Update to EnergyPlus v24.2.0a NREL/OpenStudio#5242

Merged

19 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Variable speed fan powered induction boxes #10368

Variable speed fan powered induction boxes #10368

lymereJ commented Jan 13, 2024 •

edited

Loading

nrel-bot-2 commented Feb 29, 2024

lymereJ Mar 8, 2024

lymereJ Mar 8, 2024

lymereJ Mar 8, 2024 •

edited

Loading

lymereJ Mar 14, 2024

rraustad Mar 14, 2024

lymereJ Mar 15, 2024

rraustad Mar 15, 2024 •

edited

Loading

lymereJ Mar 15, 2024

rraustad Mar 15, 2024

rraustad commented Mar 15, 2024

lymereJ commented Mar 19, 2024 •

edited

Loading

lymereJ commented Mar 19, 2024 •

edited

Loading

rraustad commented Mar 20, 2024

nrel-bot-3 commented Apr 19, 2024

Myoldmopar commented May 8, 2024

lymereJ commented May 8, 2024

lymereJ commented May 9, 2024

nrel-bot commented Jun 7, 2024

EnergyArchmage left a comment

dareumnam commented Jun 25, 2024

Myoldmopar commented Jun 25, 2024

rraustad Aug 18, 2024

jmarrec Sep 30, 2024

jmarrec Sep 30, 2024

lymereJ Sep 30, 2024

		ShowSevereError(state, format("Illegal Heating Control Type = {}", heating_control_type));
		ShowContinueError(state, format("Occurs in {} = {}", cCurrentModuleObject, thisPIU.Name));

Variable speed fan powered induction boxes #10368

Variable speed fan powered induction boxes #10368

Conversation

lymereJ commented Jan 13, 2024 • edited Loading

Pull request overview

Pull Request Author

Reviewer

nrel-bot-2 commented Feb 29, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lymereJ Mar 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad Mar 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rraustad commented Mar 15, 2024

lymereJ commented Mar 19, 2024 • edited Loading

lymereJ commented Mar 19, 2024 • edited Loading

rraustad commented Mar 20, 2024

nrel-bot-3 commented Apr 19, 2024

Myoldmopar commented May 8, 2024

lymereJ commented May 8, 2024

lymereJ commented May 9, 2024

nrel-bot commented Jun 7, 2024

EnergyArchmage left a comment

Choose a reason for hiding this comment

dareumnam commented Jun 25, 2024

Myoldmopar commented Jun 25, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lymereJ commented Jan 13, 2024 •

edited

Loading

lymereJ Mar 8, 2024 •

edited

Loading

rraustad Mar 15, 2024 •

edited

Loading

lymereJ commented Mar 19, 2024 •

edited

Loading

lymereJ commented Mar 19, 2024 •

edited

Loading