Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrects non-ASCII characters for Coil Sizing Details and other tables. #10258

Merged
merged 1 commit into from
Sep 29, 2023

Conversation

rraustad
Copy link
Contributor

@rraustad rraustad commented Sep 29, 2023

Pull request overview

NOTE: ENHANCEMENTS MUST FOLLOW A SUBMISSION PROCESS INCLUDING A FEATURE PROPOSAL AND DESIGN DOCUMENT PRIOR TO SUBMITTING CODE

Pull Request Author

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies

Reviewer

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@rraustad rraustad added the Defect Includes code to repair a defect in EnergyPlus label Sep 29, 2023
@rraustad rraustad added this to the EnergyPlus 23.2 milestone Sep 29, 2023
@rraustad
Copy link
Contributor Author

HVAC Type now shows correct text:

image

@rraustad rraustad requested a review from Myoldmopar September 29, 2023 00:04
@rraustad rraustad added the DoNotPublish Includes changes that shouldn't be reported in the changelog label Sep 29, 2023
@rraustad
Copy link
Contributor Author

From #10092 refactor merged in Jul 2023, so Do Not Publish.

image

@Myoldmopar
Copy link
Member

Thanks @rraustad, for one additional clean up. Merging this and tagging 23.2.

@Myoldmopar Myoldmopar merged commit 7636e6b into develop Sep 29, 2023
@Myoldmopar Myoldmopar deleted the HotFix-HVACType branch September 29, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Defect Includes code to repair a defect in EnergyPlus DoNotPublish Includes changes that shouldn't be reported in the changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Table reports for coil components show non-ASCII character for HVAC Type
6 participants