AirLoopHVAC:DedicatedOutoorAirSystem breaks unless AirLoopHVACs are all upper case.

[jmarrec]

Issue overview

Take SmallOffice_CentralDOAS.idf

  AirLoopHVAC:DedicatedOutdoorAirSystem,
    AirLoopHVAC DOAS,        !- Name
    AirLoopDOAS OA system,   !- AirLoopHVAC:OutdoorAirSystem Name
    ALWAYS_ON,               !- Availability Schedule Name
    AirLoopDOASMixer,        !- AirLoopHVAC:Mixer Name
    AirLoopDOASSplitter,     !- AirLoopHVAC:Splitter Name
    4.5,                     !- Preheat Design Temperature {C}
    0.004,                   !- Preheat Design Humidity Ratio {kgWater/kgDryAir}
    17.5,                    !- Precool Design Temperature {C}
    0.012,                   !- Precool Design Humidity Ratio {kgWater/kgDryAir}
    5,                       !- Number of AirLoopHVAC
-    PSZ-AC:1,                !- AirLoopHVAC 1 Name
+    PSZ-Ac:1,                !- AirLoopHVAC 1 Name
    PSZ-AC:2,                !- AirLoopHVAC 2 Name
    PSZ-AC:3,                !- AirLoopHVAC 3 Name
    PSZ-AC:4,                !- AirLoopHVAC 4 Name
    PSZ-AC:5;                !- AirLoopHVAC 5 Name

eplusout.err

   ** Severe  ** AirLoopHVAC:DedicatedOutdoorAirSystem, "AIRLOOPHVAC DOAS" AirLoopHVAC Name not found: PSZ-Ac:1
   **  Fatal  ** getAirLoopHVACDOAS: Previous errors cause termination.
   ...Summary of Errors that led to program termination:
   ..... Reference severe error count=1
   ..... Last severe error=AirLoopHVAC:DedicatedOutdoorAirSystem, "AIRLOOPHVAC DOAS" AirLoopHVAC Name not found: PSZ-Ac:

Issue is here, missing MakeUPPERCase:

EnergyPlus/src/EnergyPlus/AirLoopHVACDOAS.cc

Line 757 in c9fa4f0

std::string name = AirLoopHAVCName.at("airloophvac_name");

Details

Some additional details for this issue (if relevant):

• Platform (Operating system, version): all
• Version of EnergyPlus (if using an intermediate build, include SHA): develop, after v9.5.0-IOFreeze, c9fa4f0
• Found in testing Addresses #3728, add new DOAS to AHU objects OpenStudio-resources#120

Checklist

Add to this list or remove from it as applicable. This is a simple templated set of guidelines.

• Defect file added (list location of defect file here)
• Ticket added to Pivotal for defect (development team task)
• Pull request created (the pull request will have additional tasks related to reviewing changes that fix this defect)