-
Notifications
You must be signed in to change notification settings - Fork 401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some IDF object names can break the HTML output file #8542
Comments
Thanks for the report @santoshphilip. I added the checklist to your original post. |
The fix should also be included for the XML output file (OutputControl:Table:Style, XML) which I don't think is commonly used but would face the same issue with confused tags. |
@JasonGlazer XML is fine already: EnergyPlus/src/EnergyPlus/OutputReportTabular.cc Line 14276 in ea7967b
|
Good. To bad the author of ConvertToEscaped() didn't think of applying it to the HTML file :-) |
Added an optional boolean argument to ConvertToEscape to not convert " and ' like it would in the original routine which was meant for XML. This is to support HTML4 mostly, but might as well be correct.
I'm guessing it was you, but it's been there as far as this repo's git history can go (7+ years), so who knows when it was really added and what HTML looked like then :) |
Fix #8542 - Escape HTML characters.
Problem
Special glass <thickness is 3mm>
<thickness is 3mm>
looks like an HTML tag.Solution
Special glass <thickness is 3mm>
should becomeSpecial glass <thickness is 3mm>
<
becomes<
in the browser and>
becomes>
in the browserDetails
Some additional details for this issue (if relevant):
Checklist
Add to this list or remove from it as applicable. This is a simple templated set of guidelines.
The text was updated successfully, but these errors were encountered: