Skip to content

Commit

Permalink
Prune state
Browse files Browse the repository at this point in the history
  • Loading branch information
amirroth committed Jun 22, 2023
1 parent 2583805 commit 8f6474f
Show file tree
Hide file tree
Showing 5 changed files with 359 additions and 564 deletions.
55 changes: 0 additions & 55 deletions src/EnergyPlus/DataHVACGlobals.hh
Original file line number Diff line number Diff line change
Expand Up @@ -372,62 +372,7 @@ namespace DataHVACGlobals {

// Parameters for HVACSystemRootFindingAlgorithm
int constexpr Bisection(2);
#ifdef GET_OUT
enum class ZoneEquipType {
Invalid = -1,
DUMMY, // There is some back and forth with AFN enumerations here that I just don't want to mess with
VariableRefrigerantFlow, // VRFTerminalUnit
EnergyRecoveryVentilator, // ERVStandAlone
FourPipeFanCoil, // FanCoil4Pipe
OutdoorAirUnit, // OutdoorAirUnit
PackagedTerminalAirConditioner, // PkgTermACAirToAir
PackagedTerminalHeatPump, // PkgTermHPAirToAir
UnitHeater, // UnitHeater
UnitVentilator, // UnitVentilator
VentilatedSlab, // VentilatedSlab
WaterToAirHeatPump, // PkgTermHPWaterToAir
WindowAirConditioner, // WindowAC
BaseboardRadiantConvectiveElectric, // BBElectric
BaseboardRadiantConvectiveWater, // BBWater
BaseboardRadiantConvectiveSteam, // BBSteam
BaseboardConvectiveElectric, // BBElectricConvective
BaseboardConvectiveWater, // BBWaterConvective
HighTemperatureRadiant, // HiTempRadiant
DehumidifierDX, // ZoneDXDehumidifier
IdealLoadsAirSystem, // PurchasedAir
RefrigerationChillerSet, // RefrigerationAirChillerSet
HybridUnitaryAirConditioners,
FanZoneExhaust, // FanZoneExhaust
WaterHeaterHeatPump, // HPWaterHeater
AirTerminalDualDuctConstantVolume,
AirTerminalDualDuctVAV,
AirTerminalSingleDuctConstantVolumeReheat,
AirTerminalSingleDuctConstantVolumeNoReheat,
AirTerminalSingleDuctVAVReheat,
AirTerminalSingleDuctVAVNoReheat,
AirTerminalSingleDuctSeriesPIUReheat,
AirTerminalSingleDuctParallelPIUReheat,
AirTerminalSingleDuctCAVFourPipeInduction,
AirTerminalSingleDuctVAVReheatVariableSpeedFan,
AirTerminalSingleDuctVAVHeatAndCoolReheat,
AirTerminalSingleDuctVAVHeatAndCoolNoReheat,
AirTerminalSingleDuctConstantVolumeCooledBeam,
AirTerminalDualDuctVAVOutdoorAir,
AirLoopHVACReturnAir,
Num
};

// ZoneEvaporativeCoolerUnit
// ZoneHybridEvaporativeCooler
// AirDistUnit
// LoTempRadiant
// HeatExchanger
// UserDefinedZoneHVACForcedAir
// CoolingPanel
// ZoneUnitarySys
extern const std::array<std::string_view, (int)ZoneEquipType::Num> zoneEquipTypeNames;
extern const std::array<std::string_view, (int)ZoneEquipType::Num> zoneEquipTypeNamesUC;
#endif //
int constexpr MaxSpeedLevels = 10;

extern Array1D_string const cFanTypes;
Expand Down
25 changes: 4 additions & 21 deletions src/EnergyPlus/RoomAirModelAirflowNetwork.hh
Original file line number Diff line number Diff line change
Expand Up @@ -60,40 +60,23 @@ struct EnergyPlusData;
namespace RoomAirModelAirflowNetwork {

// Data
class RAFNData
{

private:
class RAFNData {
public:
int ZoneNum;
int RoomAirNode;

// constructor
RAFNData() : ZoneNum(0), RoomAirNode(0)
{
}
int ZoneNum = 0;
int RoomAirNode = 0;

// functions

//*****************************************************************************************
void InitRoomAirModelAirflowNetwork(EnergyPlusData &state, int const RoomAirNode); // index number for the specified zone and room air node

//*****************************************************************************************
void CalcRoomAirModelAirflowNetwork(EnergyPlusData &state,
int const ThisRoomAirNode); // index number for the specified zone and room air node

//*****************************************************************************************
void UpdateRoomAirModelAirflowNetwork(EnergyPlusData &state); // index number for the specified zone

//*****************************************************************************************
void CalcNodeSums(EnergyPlusData &state, int const RoomAirNode); // index number for the specified zone and room air node

//*****************************************************************************************
void SumNonAirSystemResponseForNode(EnergyPlusData &state, int const RoomAirNode); // index number for the specified zone and room air node
//*****************************************************************************************
void SumSystemDepResponseForNode(EnergyPlusData &state); // index number for the specified zone and room air node

//*****************************************************************************************
void SumSystemDepResponseForNode(EnergyPlusData &state); // index number for the specified zone and room air node

void CalcSurfaceMoistureSums(
EnergyPlusData &state, int const RoomAirNode, Real64 &SumHmAW, Real64 &SumHmARa, Real64 &SumHmARaW, Array1D<bool> const &SurfMask);
Expand Down
Loading

5 comments on commit 8f6474f

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACGlobals1 (amirroth) - Win64-Windows-10-VisualStudio-16: OK (2663 of 2663 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACGlobals1 (amirroth) - x86_64-MacOS-10.17-clang-13.0.0: OK (3436 of 3436 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACGlobals1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.3: OK (3477 of 3477 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACGlobals1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.3-UnitTestsCoverage-Debug: OK (1890 of 1890 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HVACGlobals1 (amirroth) - x86_64-Linux-Ubuntu-22.04-gcc-11.3-IntegrationCoverage-Debug: OK (776 of 777 tests passed, 0 test warnings)

Failures:\n

integration Test Summary

  • Passed: 776
  • Failed: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.