Skip to content

Commit

Permalink
Intermediate commit for Unit test question
Browse files Browse the repository at this point in the history
  • Loading branch information
jmythms committed Feb 9, 2021
1 parent fd33e3e commit 7fbaa76
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions tst/EnergyPlus/unit/PurchasedAirManager.unit.cc
Original file line number Diff line number Diff line change
Expand Up @@ -643,18 +643,24 @@ TEST_F(ZoneIdealLoadsTest, IdealLoads_IntermediateOutputVarsTest)

EXPECT_EQ(PurchAir(1).Name, "ZONE 1 IDEAL LOADS");
// Ideal loads air system found the plenum it is attached to
EXPECT_EQ(PurchAir(1).SupplyTemp, Node(PurchAir(1).ZoneSupplyAirNodeNum).Temp); //

// Is this the best condition to check/test SupplyTemp and SupplyHumRat? It should be always equal to Zone Supply Node conditions, but is that a sufficient condition?
EXPECT_EQ(PurchAir(1).SupplyTemp, Node(PurchAir(1).ZoneSupplyAirNodeNum).Temp);
EXPECT_EQ(PurchAir(1).SupplyHumRat, Node(PurchAir(1).ZoneSupplyAirNodeNum).HumRat);

//Can't figure out what would be a good test for MixedAirTemp/MixedAirHumRat. I wanted to implement a test with outdoor
// air as well, since MixedAirTemp/MixedAirHumRat would be the conditions after mixing OA with the incoming stream.
// But I cannot seem to hold the temperature at IdealLoadsSystem inlet (same conditions as ZoneExhaustAirNodeNum) which
// keeps falling to zero.
Node(PurchAir(1).ZoneExhaustAirNodeNum).Temp = 35;
Node(PurchAir(1).OutdoorAirNodeNum).Temp = 10;
ManageZoneEquipment(*state,
FirstHVACIteration,
SimZone,
SimAir); // read zone equipment configuration and list objects and simulate ideal loads air system
EXPECT_EQ(0, Node(PurchAir(1).ZoneExhaustAirNodeNum).Temp);
EXPECT_EQ(0, Node(PurchAir(1).OutdoorAirNodeNum).Temp);
EXPECT_EQ(PurchAir(1).MixedAirTemp, Node(PurchAir(1).ZoneExhaustAirNodeNum).Temp);
EXPECT_EQ(PurchAir(1).MixedAirHumRat, Node(PurchAir(1).ZoneExhaustAirNodeNum).HumRat);
}

TEST_F(ZoneIdealLoadsTest, IdealLoads_EMSOverrideTest)
Expand Down

4 comments on commit 7fbaa76

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add-New-Zone-Ideal-Loads-Output-Variables (jmythms) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3036 of 3037 tests passed, 75 test warnings)

Messages:\n

  • 76 tests had: AUD diffs.
  • 73 tests had: RDD diffs.
  • 1 test had: MTD diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 736
  • Failed: 1

Build Badge Test Badge

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add-New-Zone-Ideal-Loads-Output-Variables (jmythms) - x86_64-MacOS-10.15-clang-11.0.0: OK (2996 of 2997 tests passed, 73 test warnings)

Messages:\n

  • 74 tests had: AUD diffs.
  • 71 tests had: RDD diffs.
  • 1 test had: MTD diffs.
  • 1 test had: Table big diffs.

Failures:\n

regression Test Summary

  • Passed: 716
  • Failed: 1

Build Badge Test Badge

@nrel-bot-2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add-New-Zone-Ideal-Loads-Output-Variables (jmythms) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1561 of 1561 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add-New-Zone-Ideal-Loads-Output-Variables (jmythms) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (722 of 722 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.