Skip to content

Commit

Permalink
Merge pull request #8401 from NREL/6050_ReturnFan_MinFlowFrac
Browse files Browse the repository at this point in the history
Fix #6050 - Return Fan:VariableVolume Fan Power Minimum Flow Fraction should not impose air loop flow
  • Loading branch information
mitchute authored Dec 11, 2020
2 parents edb5081 + f99ad62 commit 1cdc5c5
Show file tree
Hide file tree
Showing 2 changed files with 531 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/EnergyPlus/Fans.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1105,7 +1105,10 @@ namespace Fans {

// Init the Node Control variables
Node(OutNode).MassFlowRateMax = Fan(FanNum).MaxAirMassFlowRate;
Node(OutNode).MassFlowRateMin = Fan(FanNum).MinAirMassFlowRate;
// According to the IO Ref guide:
// "Note that this field is only used to calculate the fan power.
// This field does not enforce the system air flow rate during simulation"
// Node(OutNode).MassFlowRateMin = Fan(FanNum).MinAirMassFlowRate;

// Initialize all report variables to a known state at beginning of simulation
Fan(FanNum).FanPower = 0.0;
Expand Down
Loading

5 comments on commit 1cdc5c5

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-MacOS-10.15-clang-11.0.0: OK (2280 of 2280 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - Win64-Windows-10-VisualStudio-16: OK (2253 of 2253 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (2300 of 2300 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1562 of 1562 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

develop (mitchute) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: Coverage Too Low

Failures:\n

integration Test Summary

  • Passed: 720
  • Timeout: 1

Build Badge Test Badge Coverage Badge

Please sign in to comment.