Skip to content

Commit

Permalink
Merge remote-tracking branch 'remotes/origin/develop' into EnhanceOut…
Browse files Browse the repository at this point in the history
…doorAirReporting2
  • Loading branch information
mjwitte committed Feb 17, 2021
2 parents 13496df + ea7967b commit 0cc3832
Showing 1 changed file with 8 additions and 2 deletions.
10 changes: 8 additions & 2 deletions src/EnergyPlus/MatrixDataManager.cc
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,13 @@ namespace MatrixDataManager {
// Object Data
Array1D<MatrixDataStruct> MatData;

// Functions

// MSVC was complaining that it detected a divide by zero in the Row = (El - 1) / NumCols + 1 line, indicating it thought NumCols was zero
// the compiler should never have been able to identify that, as NumCols is based directly on rNumericArgs, which is based on input values
// Apparently, interaction between the high level optimizer that does flow-graph transformations and backend that emits warnings can cause
// false positives. The warning simply needs to be muted. Placing the pragma at the statement itself was not sufficient for muting, so I
// placed the pragma out here at this level and it worked. Note that this warning was only showing up on release builds, not debug builds
#pragma warning( push )
#pragma warning( disable : 4723 )
void GetMatrixInput(EnergyPlusData &state)
{

Expand Down Expand Up @@ -190,6 +195,7 @@ namespace MatrixDataManager {
ShowFatalError(state, "GetMatrixInput: Errors found in Matrix objects. Preceding condition(s) cause termination.");
}
}
#pragma warning( pop )

int MatrixIndex(EnergyPlusData &state, std::string const &MatrixName)
{
Expand Down

5 comments on commit 0cc3832

@nrel-bot-3
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting2 (mjwitte) - x86_64-MacOS-10.15-clang-11.0.0: OK (3016 of 3016 tests passed, 716 test warnings)

Messages:\n

  • 716 tests had: AUD diffs.
  • 702 tests had: RDD diffs.

Build Badge Test Badge

@nrel-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting2 (mjwitte) - Win64-Windows-10-VisualStudio-16: OK (2272 of 2272 tests passed, 0 test warnings)

Build Badge Test Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting2 (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5: OK (3056 of 3056 tests passed, 720 test warnings)

Messages:\n

  • 720 tests had: AUD diffs.
  • 706 tests had: RDD diffs.

Build Badge Test Badge

@nrel-bot-2b
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting2 (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-UnitTestsCoverage-Debug: OK (1580 of 1580 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

@nrel-bot-2c
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EnhanceOutdoorAirReporting2 (mjwitte) - x86_64-Linux-Ubuntu-18.04-gcc-7.5-IntegrationCoverage-Debug: OK (722 of 722 tests passed, 0 test warnings)

Build Badge Test Badge Coverage Badge

Please sign in to comment.