Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EUSS Demand Flexibility measure updates #124

Merged
merged 73 commits into from
Feb 27, 2024

Conversation

JieXiong9119
Copy link
Collaborator

Pull request overview

Code updates for demand flexibility measures
-- thermostat control load shed
-- thermostat control load shift
-- dispatch schedule generation (supplemental)

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

ComStock Licensing Language - Add to Beginning of Each Code File

# ComStock™, Copyright (c) 2023 Alliance for Sustainable Energy, LLC. All rights reserved.
# See top level LICENSE.txt file for license terms.

@JieXiong9119 JieXiong9119 added the upgrade measure PR improves or adds upgrade measures label Feb 24, 2024
@JieXiong9119 JieXiong9119 self-assigned this Feb 24, 2024
@ChristopherCaradonna ChristopherCaradonna merged commit 9c22e30 into main Feb 27, 2024
@ChristopherCaradonna ChristopherCaradonna deleted the jx/df-thermostat-control branch February 27, 2024 14:37
@mdahlhausen mdahlhausen changed the title EUSS cycle 3 Demand Flexibility measures updates EUSS Demand Flexibility measures Mar 13, 2024
@mdahlhausen mdahlhausen changed the title EUSS Demand Flexibility measures EUSS Demand Flexibility measure updates Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
upgrade measure PR improves or adds upgrade measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants