Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix economizer damper fault schedule #108

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

JanghyunJK
Copy link
Contributor

@JanghyunJK JanghyunJK commented Jan 29, 2024

Pull request overview

  • this is a fix following up from previous PR: Fix applicability logic for EUSS economizer fault measures #30

  • economizer damper fault measure tweaks min/max oa fraction schedule in controller:outdoorair object

  • but it did not properly set the schedule type in EMS actuator when there were existing schedules

  • so,

    • made a fix to understand what existing sch types are
    • and also did some cleaning
  • Fixes Baseline economizer fault measure causing model failures #106

  • description added to the change doc as well.

  • 10k test results:

    • before fix: Upgrade 0 failure rate was 0.045 (450 of 10000 simulations), which is above the specified acceptable limit of 0.025.
    • after fix: Upgrade 0 failure rate was 0.0123 (123 of 10000 simulations), which is above the specified acceptable limit of 0.01.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Infrastructure (includes singularity image, buildstock batch, dependencies, continuous integration tests)
  • Sampling
  • Workflow Measures
  • Upgrade Measures
  • Reporting Measures
  • Postprocessing

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Added tests for new measures
  • Updated measure .xml(s)
  • Register values added to comstock_column_definitions.csv
  • Both options_lookup.tsv files updated
  • 10k+ test run
  • Change documentation written
  • Measure documentation written
  • ComStock documentation updated
  • Changes reflected in example .yml files
  • Changes reflected in README.md files
  • Added 'See ComStock License' language to first two lines of each code file
  • Implements corresponding measure tests and indexing path in test/measure_tests.txt or/and test/resource_measure_tests.txt
  • All new and existing tests pass the CI

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Ensured code files contain License reference
  • Results differences are reasonable
  • Make sure the newly added measures has been added with tests and indexed properly
  • CI status: all tests pass

@JanghyunJK JanghyunJK added the workflow measure PR improves or adds baseline workflow measures label Jan 29, 2024
@JanghyunJK JanghyunJK self-assigned this Jan 29, 2024
@JanghyunJK JanghyunJK changed the title [WIP] economizer damper fault sch type fix economizer damper fault sch type fix Jan 31, 2024
@ChristopherCaradonna ChristopherCaradonna merged commit eea3ae0 into main Feb 1, 2024
@ChristopherCaradonna ChristopherCaradonna deleted the jk/economizer-damper-fault-fix branch February 1, 2024 04:09
@mdahlhausen mdahlhausen changed the title economizer damper fault sch type fix Fix economizer damper fault schedule Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Baseline economizer fault measure causing model failures
2 participants