Fix economizer damper fault schedule #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
this is a fix following up from previous PR: Fix applicability logic for EUSS economizer fault measures #30
economizer damper fault measure tweaks min/max oa fraction schedule in
controller:outdoorair
objectbut it did not properly set the schedule type in EMS actuator when there were existing schedules
so,
Fixes Baseline economizer fault measure causing model failures #106
description added to the change doc as well.
10k test results:
Upgrade 0 failure rate was 0.045 (450 of 10000 simulations), which is above the specified acceptable limit of 0.025.
Upgrade 0 failure rate was 0.0123 (123 of 10000 simulations), which is above the specified acceptable limit of 0.01.
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
comstock_column_definitions.csv
options_lookup.tsv
files updated.yml
filesREADME.md
filestest/measure_tests.txt
or/andtest/resource_measure_tests.txt
Review Checklist
This will not be exhaustively relevant to every PR.