Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce model design days #105

Merged
merged 3 commits into from
Jan 29, 2024
Merged

Reduce model design days #105

merged 3 commits into from
Jan 29, 2024

Conversation

mdahlhausen
Copy link
Contributor

@mdahlhausen mdahlhausen commented Jan 26, 2024 •
edited
Loading

Pull request overview

This PR reduces the number of design days added to the models to just 6, instead of all monthly and annual design days. It reduces runtime by around 40%.

Pull Request Author

This pull request makes changes to (select all the apply):

  • Documentation
  • Workflow Measures

Author pull request checklist:

  • Tagged the pull request with the appropriate label (documentation, infrastructure, sampling, workflow measure, upgrade measure, reporting measure, postprocessing) to help categorize changes in the release notes.
  • Updated measure .xml(s)
  • 10k+ test run
  • Change documentation written
  • ComStock documentation updated

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a code review on GitHub
  • All related changes have been implemented: data and method additions, changes, tests
  • If fixing a defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • Reviewed change documentation
  • Results differences are reasonable
  • CI status: all tests pass

@mdahlhausen mdahlhausen added documentation PR improves or adds documentation workflow measure PR improves or adds baseline workflow measures labels Jan 26, 2024
asparke2
asparke2 approved these changes Jan 29, 2024
View reviewed changes
Copy link
Member

@asparke2 asparke2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mdahlhausen looks good to me! @ChristopherCaradonna check this runtime reduction out if you haven't seen it, definitely want this merged in for EUSS runs.

image

@asparke2 asparke2 merged commit 3013d13 into main Jan 29, 2024
@asparke2 asparke2 deleted the fix/reduce_design_days branch January 29, 2024 20:32
@mdahlhausen mdahlhausen changed the title Reduce design days Reduce model design days Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eringold eringold eringold approved these changes

@asparke2 asparke2 asparke2 approved these changes

Assignees

@asparke2 asparke2

@eringold eringold

Labels
documentation PR improves or adds documentation workflow measure PR improves or adds baseline workflow measures
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reduce number of design days added to model
3 participants
@mdahlhausen @asparke2 @eringold