Reduce total occupancy #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/occupant_adjustment
…/occupant_adjustment
asparke2
requested changes
Jan 24, 2024
resources/measures/adjust_occupancy_schedule/resources/os_lib_schedules.rb
Outdated
Show resolved
Hide resolved
mdahlhausen
reviewed
Jan 25, 2024
mdahlhausen
added
the
workflow measure
mdahlhausen
requested changes
Jan 25, 2024
There was a problem hiding this comment.
The change documentation looks great - thanks for including all the comparisons!
A few minor changes:
- Copy methods from openstudio-standards instead of using the methods in os_lib_schedules.rb. That will make it easier to refactor in the future.
- Update the workflow measures README with this measure.
- Add ComStock license to files.
- Update ComStock documentation in the occupancy section to explain this update.
-remove oslib_schedules -copy new standards methods to be replaced -descriptive schedule name with rounded value -test runs, output the same -add copyright -update measure xml
|
@asparke2 @mdahlhausen Thanks for the review. I think I've addressed all comments, let me know if there's anything else you'd like to see, particularly on the documentation. |
mdahlhausen
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request overview
Adjusts building occupancy schedules to closer align ComStock occupancy with US Commercial Building occupancy as determined from American Time Use Survey data.
ComStock Change Document
Pull Request Author
This pull request makes changes to (select all the apply):
Author pull request checklist:
options_lookup.tsvfiles updatedReview Checklist
This will not be exhaustively relevant to every PR.
ComStock Licensing Language - Add to Beginning of Each Code File