[DRAFT] [PSY5] Add 3W Transformer Struct #1247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `with_units_base` feature
Fix for nothings in VOM table data parser
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 3WTransformer #1247 +/- ##
================================================
Coverage ? 84.43%
================================================
Files ? 182
Lines ? 8491
Branches ? 0
================================================
Hits ? 7169
Misses ? 1322
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more.
|
jd-lara
reviewed
Jan 13, 2025
| r_tertiary::Float64 | ||
| x_tertiary::Float64 | ||
| rating::Union{Nothing, Float64} | ||
| r_12::Float64 |
There was a problem hiding this comment.
are these for the Y equivalent?
There was a problem hiding this comment.
Yes, the r_primary and those are the ones that are the equivalent, the r12 and those, are the direct params from PSSE
jd-lara
requested changes
Jan 13, 2025
|
@GabrielKS can you confirm this has everything we need to export the 3W transformer as well please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial idea for 3W transformer based on PSSE.
We are not giving support to any tap voltage control (i.e.
COD1 = COD2 = COD3 = 0), and we are assuming that all the data must come in system per unit. These requires the flagsCW = CZ = CM = 1.