Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add base power default to Source #1173

Merged
merged 2 commits into from
Aug 6, 2024
Merged

add base power default to Source #1173

merged 2 commits into from
Aug 6, 2024

Conversation

rodrigomha
Copy link
Contributor

No description provided.

@rodrigomha rodrigomha requested a review from GabrielKS August 5, 2024 21:58
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 84.52%. Comparing base (ebfc66c) to head (9405461).
Report is 1 commits behind head on main.

Files Patch % Lines
src/models/generated/Source.jl 66.66% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1173   +/-   ##
=======================================
  Coverage   84.51%   84.52%           
=======================================
  Files         179      179           
  Lines        8165     8167    +2     
=======================================
+ Hits         6901     6903    +2     
  Misses       1264     1264           
Flag Coverage Δ
unittests 84.52% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/models/generated/Source.jl 93.75% <66.66%> (+0.41%) ⬆️

@rodrigomha rodrigomha requested a review from jd-lara August 6, 2024 04:24
Copy link
Member

@jd-lara jd-lara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We need to open an issue in PowerFlows to implement this logic correctly.

@jd-lara jd-lara merged commit c932c0b into main Aug 6, 2024
10 of 11 checks passed
@jd-lara jd-lara deleted the rh/add_base_power_to_source branch December 13, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants