Add Honduras structs #1158
Merged
Add Honduras structs #1158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1158 +/- ##
==========================================
+ Coverage 84.62% 84.78% +0.16%
==========================================
Files 177 182 +5
Lines 8115 8346 +231
==========================================
+ Hits 6867 7076 +209
- Misses 1248 1270 +22
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rodrigomha
commented
Jul 17, 2024
| m = match(r"^\((\d+)\s*,\s*(\d+)\)$", _v) | ||
| m2 = match(r"^\((\d+)\s*,\s*(\d+),\s*(\d+)\)$", _v) |
There was a problem hiding this comment.
@jd-lara Any idea how to generalize this Regex for a tuple of n-length? The PIDGOV model and WPIDHY models have a tuple with three terms.
There was a problem hiding this comment.
Let's do this for another time. For now this should be fine
jd-lara
reviewed
Jul 17, 2024
| @@ -153,3 +153,13 @@ function _calc_states(machine, shaft, avr, prime_mover, pss) | |||
| get_states(pss), | |||
| ) | |||
| end | |||
|
|
|||
| function get_degov1_states(droop_flag::Int) | |||
There was a problem hiding this comment.
we can put this in the code auto generator.
jd-lara
reviewed
Jul 17, 2024
| """Get [`DEGOV1`](@ref) `ext`.""" | ||
| get_ext(value::DEGOV1) = value.ext | ||
| """Get [`DEGOV1`](@ref) `states`.""" | ||
| get_states(value::DEGOV1) = value.states |
There was a problem hiding this comment.
Suggested change
| get_states(value::DEGOV1) = value.states | |
| get_states(value::DEGOV1) = get_degov1_states(value) |
jd-lara
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.