Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change implementation of parameters #899

Merged
merged 86 commits into from
Dec 22, 2022
Merged

change implementation of parameters #899

merged 86 commits into from
Dec 22, 2022

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Dec 20, 2022

This is a big PR. Some tests are still broken (Hybrid Systems models). Opening the PR for initial review and to run the CI and merge to unblock work and then address the hybrid devices issues.

This was linked to issues Dec 21, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 21, 2022

Performance Results

Version Precompile Time
Master 14.028002801
This Branch 14.07893499
Version Build Time
Master-Build Time Precompile 92.643516983
Master-Build Time Postcompile 12.388326805
This Branch-Build Time Precompile 93.560284471
This Branch-Build Time Postcompile 12.771829474

test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #899 (9adbfed) into master (6320924) will decrease coverage by 1.53%.
The diff coverage is 83.02%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #899      +/-   ##
==========================================
- Coverage   85.24%   83.71%   -1.54%     
==========================================
  Files         116      117       +1     
  Lines       12524    12654     +130     
==========================================
- Hits        10676    10593      -83     
- Misses       1848     2061     +213     
Flag Coverage Δ
unittests 83.71% <83.02%> (-1.54%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/PowerSimulations.jl 100.00% <ø> (ø)
src/core/definitions.jl 50.00% <ø> (ø)
src/core/device_model.jl 88.00% <ø> (ø)
src/core/formulations.jl 100.00% <ø> (ø)
src/core/variables.jl 65.51% <ø> (-0.40%) ⬇️
...els/device_constructors/constructor_validations.jl 18.75% <ø> (-2.47%) ⬇️
.../devices_models/devices/common/range_constraint.jl 81.06% <ø> (ø)
src/feedforward/feedforward_constraints.jl 83.97% <ø> (ø)
...rc/initial_conditions/update_initial_conditions.jl 100.00% <ø> (ø)
src/operation/emulation_model.jl 87.20% <0.00%> (-1.03%) ⬇️
... and 46 more

test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
test/test_utils/mock_operation_models.jl Outdated Show resolved Hide resolved
@jd-lara jd-lara marked this pull request as ready for review December 21, 2022 00:42
@jd-lara jd-lara linked an issue Dec 21, 2022 that may be closed by this pull request
@jd-lara jd-lara merged commit c10ab36 into master Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove ordered dict deprecated use UndefVarError: parameter_type not defined Parameter update
3 participants