merge dt changes #815
merge dt changes #815
Conversation
Update SimulationResults to match newer interfaces
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
store refactors
| end | ||
|
|
||
| function read_optimizer_stats(store::InMemorySimulationStore, model_name) | ||
| # TODO EmulationModel: this interface is TBD |
There was a problem hiding this comment.
Does something need to change here?
There was a problem hiding this comment.
Yeah, this is not implemented yet. I need to do this in a separate PR with the caching.
| for field in fieldnames(ValueStates) | ||
| model_params = get_model_params(store, model_name) | ||
| model_params = get_decision_model_params(store, model_name) | ||
| for field in fieldnames(DatasetContainer) | ||
| for key in list_fields(store, model_name, field) | ||
| # TODO: Read Array here to avoid allocating the DataFrame |
There was a problem hiding this comment.
Does this TODO still apply? I guess it's tied to my other comment about making a non-copy read_results function.
There was a problem hiding this comment.
Yes, it does apply. But after testing I wonder how much it matters.
| result_length = length(first_id:last_id) | ||
| for colname in propertynames(df) | ||
| colname == :DateTime && continue | ||
| # TODO DT: may not be correct |
There was a problem hiding this comment.
Can we confirm this and then delete the comment?
There was a problem hiding this comment.
I can't confirm it is correct at the moment. @claytonpbarrows was assigned the validation. We should leave the comment and merge to dev for further testing of the results code.
Opening a PR because this branch is already pretty large. Check the comments for the pending development functions.