Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DNMY] Support in the loop PowerFlow evaluation #1040

Draft
wants to merge 50 commits into
base: main
Choose a base branch
from

Conversation

jd-lara
Copy link
Member

@jd-lara jd-lara commented Jan 9, 2024

This is a WIP branch to integrate the evaluation of PowerFlows into a simulation loop.

GKS edit: depends on NREL-Sienna/PowerFlows.jl#53

src/core/network_model.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
Base automatically changed from jd/radial_branch_reduction to main January 22, 2024 22:31
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/core/powerflow_data_wrapper.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
src/network_models/powerflow_evaluation.jl Outdated Show resolved Hide resolved
@GabrielKS
Copy link
Contributor

Requires NREL-Sienna/PowerFlows.jl#48.

@GabrielKS GabrielKS self-assigned this Nov 4, 2024
@GabrielKS
Copy link
Contributor

@jd-lara I can't tag you for review on this since it's technically your PR, so this is me letting you know that this is ready for review. There's a few TODOs that I'd like to think about a bit more, but I think it'd be good to get your eyes on it now.

@jd-lara
Copy link
Member Author

jd-lara commented Jan 3, 2025

One issue to consider is the following, in Models with unit commitment (hydro and thermal) if the unit is connected to a PV Bus bus it is essentially off the bus type needs to change to PQ to make the power flow problem feasible. This implies that we need an aux variable for the bus type and then enact that change both in the call to solve as well as in the exporter for any models of the subtype Commitment

Union{String, Int64}} mapping component name/bus number to component name/bus number.
"""
input_key_map::Dict{<:OptimizationContainerKey, <:Any}
input_key_map::Dict{Symbol, <:Dict{<:OptimizationContainerKey, <:Any}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separate dicts for active and reactive power, basically. There were other ways to do it but I think this is the most natural.

# association
for entry_type in precedence
for (key, val) in available_keys
(get_entry_type(key) === entry_type) || continue
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make this if statement for readability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

3 participants