Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace cat with preallocated array to fix stackoverflow issue #1027

Merged
merged 1 commit into from
Dec 13, 2023

replace cat with preallocated array

b11bfd9
Select commit
Loading
Failed to load commit list.
Merged

Replace cat with preallocated array to fix stackoverflow issue #1027

replace cat with preallocated array
b11bfd9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 13, 2023 in 0s

79.82% (-0.03%) compared to 3f6e556

View this Pull Request on Codecov

79.82% (-0.03%) compared to 3f6e556

Details

Codecov Report

Merging #1027 (b11bfd9) into main (3f6e556) will decrease coverage by 0.03%.
The diff coverage is 71.42%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1027      +/-   ##
==========================================
- Coverage   79.85%   79.82%   -0.03%     
==========================================
  Files         116      116              
  Lines       12457    12414      -43     
==========================================
- Hits         9948     9910      -38     
+ Misses       2509     2504       -5     
Files Coverage Δ
src/simulation/optimization_output_cache.jl 93.84% <71.42%> (-6.16%) ⬇️

... and 18 files with indirect coverage changes