Add support for external PR review timestamp filtering in getTeamMemb…

…erReviews (#323)
NOUIY · Nov 21, 2024 · bf30ae8 · bf30ae8
1 parent d81cacb
commit bf30ae8
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 2 deletions.
diff --git a/code-review-chat/CodeReviewChat.js b/code-review-chat/CodeReviewChat.js
diff --git a/code-review-chat/CodeReviewChat.ts b/code-review-chat/CodeReviewChat.ts
@@ -360,6 +360,7 @@ export async function getTeamMemberReviews(
 	repo: string,
 	owner: string,
 	ghIssue: GitHubIssue | OctoKitIssue,
+	isExternalPR?: boolean,
 ) {
 	const reviews = await octokit.pulls.listReviews({
 		pull_number: prNumber,
@@ -401,6 +402,13 @@ export async function getTeamMemberReviews(
 		if (reviewTimestamp < lastCommitUnixTimestamp) {
 			continue;
 		}
+
+		// Check that the team member review occurred in the last 24 hours for external PRs
+		const twentyFourHoursAgo = Date.now() - 24 * 60 * 60 * 1000;
+		if (isExternalPR && reviewTimestamp < twentyFourHoursAgo) {
+			continue;
+		}
+
 		const existingReview = latestReviews.get(review.user.login);
 		if (!existingReview || reviewTimestamp > new Date(existingReview.submitted_at).getTime()) {
 			latestReviews.set(review.user.login, review);

diff --git a/code-review-chat/index.js b/code-review-chat/index.js
diff --git a/code-review-chat/index.ts b/code-review-chat/index.ts
@@ -135,6 +135,7 @@ class CodeReviewChatAction extends Action {
 				payload.repository.name,
 				payload.repository.owner.login,
 				issue,
+				true /* isExternalPR */,
 			);
 			safeLog(`Found ${teamMemberReviews?.length ?? 0} reviews from team members`);
 			// Get only the approving reviews from team members