Code

#737: SCHISM Coastal Formulation#810

Code

Draft

PhilMiller wants to merge 56 commits intoNOAA-OWP:masterNOAA-OWP/ngen:masterfrom PhilMiller:PhilMiller/coastal-schismPhilMiller/NOAA-OWP-ngen:PhilMiller/coastal-schismCopy head branch name to clipboard

+1,289-353

Commits

Commits on Aug 16, 2024

• NOAA-OWP#737: Initial draft of Coastal Formulation interface, SCHISM implementation, and supporting classes

  PhilMiller

  committed
  c0294b2

  Copy full SHA for c0294b2

• Clean up compiler issues

  PhilMiller

  committed
  a57659f

  Copy full SHA for a57659f

• Another compilation fix

  PhilMiller

  committed
  4d43b38

  Copy full SHA for 4d43b38

• More work toward Schism Formulation implementation

  PhilMiller

  committed
  af3166f

  Copy full SHA for af3166f

• Reword

  PhilMiller

  committed
  d07ebf8

  Copy full SHA for d07ebf8

• Adjust for refactor

  PhilMiller

  committed
  17a8bfd

  Copy full SHA for 17a8bfd

• Typo fix

  PhilMiller

  committed
  28809e0

  Copy full SHA for 28809e0

• Parameterize SCHISM library path

  PhilMiller

  committed
  f345e6d

  Copy full SHA for f345e6d

• Update to match const-qualification changes

  PhilMiller

  committed
  25209b0

  Copy full SHA for 25209b0

• Match added argument

  PhilMiller

  committed
  e003e76

  Copy full SHA for e003e76

• Start outlining main implementation

  PhilMiller

  committed
  7478cd2

  Copy full SHA for 7478cd2

• Finalize forcings/boundary providers

  PhilMiller

  committed
  68dc991

  Copy full SHA for 68dc991

• List variables to set up before Update

  PhilMiller

  committed
  6fa3c18

  Copy full SHA for 6fa3c18

• Stylize argument-naming comment

  PhilMiller

  committed
  04c9cf5

  Copy full SHA for 04c9cf5

• Tweak definition of all_points to clarify call site usage

  PhilMiller

  committed
  4d55b6c

  Copy full SHA for 4d55b6c

• Conditionalize on Fortran support

  PhilMiller

  committed
  67e17c8

  Copy full SHA for 67e17c8

• Start handling input variable setup

  PhilMiller

  committed
  c366014

  Copy full SHA for c366014

• Sketch time keeping members

  PhilMiller

  committed
  706046b

  Copy full SHA for 706046b

• Call BMI Init function

  PhilMiller

  committed
  1751125

  Copy full SHA for 1751125

• Move input variable setup from ctor to Initialize

  PhilMiller

  committed
  2dba565

  Copy full SHA for 2dba565

Commits on Aug 19, 2024

• Match SCHISM BMI's registration/instantiaion function name

  PhilMiller

  committed
  d687db0

  Copy full SHA for d687db0

Commits on Aug 23, 2024

• Fix declaration of all_points to avoid linking errors on duplicate definition

  PhilMiller

  committed
  b7d1eba

  Copy full SHA for b7d1eba

• Conditionalize SCHISM code on Fortran and MPI support

  PhilMiller

  committed
  9b5716e

  Copy full SHA for 9b5716e

• Square away virtual method implementation

  PhilMiller

  committed
  fa6c223

  Copy full SHA for fa6c223

• Typo fix in variable name

  PhilMiller

  committed
  56783a3

  Copy full SHA for 56783a3

• Bmi_Fortran_Adapter: Add MPI-specific constructor

  PhilMiller

  committed
  23725d1

  Copy full SHA for 23725d1

• SchismFormulation: Match usage to Bmi_Fortran_Adapter constructor taking MPI_Comm (which calls BMI initialize)

  PhilMiller

  committed
  d618d80

  Copy full SHA for d618d80

Commits on Aug 26, 2024

• Require MPI for the test

  PhilMiller

  committed
  c7eaf3e

  Copy full SHA for c7eaf3e

• Enumerate output variables

  PhilMiller

  committed
  8b4d612

  Copy full SHA for 8b4d612

• Implement mesh_size method

  PhilMiller

  committed
  90b33d9

  Copy full SHA for 90b33d9

• Implement get_values

  PhilMiller

  committed
  9d74eb2

  Copy full SHA for 9d74eb2

• Generalize output string

  PhilMiller

  committed
  b9c1237

  Copy full SHA for b9c1237

• Position comments better

  PhilMiller

  committed
  ffb7057

  Copy full SHA for ffb7057

• Square up time types

  PhilMiller

  committed
  5835aac

  Copy full SHA for 5835aac

• Implement much of forcings

  PhilMiller

  committed
  686a706

  Copy full SHA for 686a706

Commits on Aug 27, 2024

• Split parallel_utils.h to header/source, and make bits usable from multiple calling objects

  PhilMiller

  committed
  bbe5c5f

  Copy full SHA for bbe5c5f

• Initialize input variables

  PhilMiller

  committed
  b850742

  Copy full SHA for b850742

• Finalize input providers since mock is now set

  PhilMiller

  committed
  0b0a237

  Copy full SHA for 0b0a237

• Single-step test with mocked inputs, works for mpiexec -np 1

  PhilMiller

  committed
  d9bcb52

  Copy full SHA for d9bcb52

Commits on Sep 17, 2024

• Annotate override

  PhilMiller

  committed
  b190797

  Copy full SHA for b190797

• Firm up MeshPointsSelector

  PhilMiller

  committed
  ebaa00d

  Copy full SHA for ebaa00d

• Mostly implemented NetCDF unstructured mesh reader for coastal formulation use

  PhilMiller

  committed
  eaac987

  Copy full SHA for eaac987

• Drop unused member variable

  PhilMiller

  committed
  aab3cdc

  Copy full SHA for aab3cdc

• Remove unused instance and value caching from NetCDF mesh provider

  PhilMiller

  committed
  9fd9510

  Copy full SHA for 9fd9510

• Clear out some residual cruft

  PhilMiller

  committed
  5ed7fd5

  Copy full SHA for 5ed7fd5

• DataProvider: Add nicer interface to base class

  PhilMiller

  committed
  852c31c

  Copy full SHA for 852c31c

• NetCDF mesh data provider: fix up time keeping

  PhilMiller

  committed
  5d2ed33

  Copy full SHA for 5d2ed33

Commits on Sep 18, 2024

• Adjust Schism formulation and test to exploit new NetCDF mesh data provider

  PhilMiller

  committed
  1b29181

  Copy full SHA for 1b29181

• Time logic cleanup

  PhilMiller

  committed
  6a2a3dd

  Copy full SHA for 6a2a3dd

• SCHISM Formulation: Pass MPI communicator as constructor argument

  PhilMiller

  committed
  b22f210

  Copy full SHA for b22f210

Commits on Sep 30, 2024

• Fix missing headers and conditional return in non-Python path

  PhilMiller

  committed
  d680b07

  Copy full SHA for d680b07

Commits on Nov 26, 2024

• Improve error reporting slightly

  PhilMiller

  committed
  6f7fc16

  Copy full SHA for 6f7fc16

• Use appropriate type aliases more thoroughly

  PhilMiller

  committed
  61be140

  Copy full SHA for 61be140

Commits on Dec 2, 2024

• CMakeLists: Format

  PhilMiller

  committed
  8eca58c

  Copy full SHA for 8eca58c

• Adapt to updated SCHISM BMI implementation

  PhilMiller

  committed
  86a5271

  Copy full SHA for 86a5271

Commits on Dec 11, 2024

• Rename data provider in consultation with Jason Ducker

  PhilMiller

  committed
  4e9625f

  Copy full SHA for 4e9625f