Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address tabulation performance #163

Merged
merged 6 commits into from
Oct 12, 2023
Merged

Conversation

GregoryPetrochenkov-NOAA
Copy link
Collaborator

@GregoryPetrochenkov-NOAA GregoryPetrochenkov-NOAA commented Oct 6, 2023

This pull request addresses #162 .

Changes

  • Two-class, multi-class, and continuous notebooks: Updated backend provider for plots
  • pyproject.toml: Updated version
  • gval_xarray: Updated workflow for computing cross-tabulation tables from agreement maps, added functionality to parse string attributes if they exist and convert relevant attributes to strings if need be
  • agreement.py: Added pairing dictionary to agreement map
  • compute_categorical_metrics.py: get all unique values if they are not lists (issue to be addressed)
  • tabulation.py: Remove xarray spatial crosstab and instead use flox groupby count
  • spatial_alignment.py: Use odc reproject (generalizable for numpy and dask) instead of reproject match
  • categorical_statistics.py: Handle all invalid input quietly
  • schemas.py: Allow candidate and benchmark values to be null and account for future list (issue to be addressed)
  • visualize.py: Change backend provider
  • test compare/accessors/catalogs cases compare/accessors: Modified tests given change in workflow

pyproject.toml Outdated Show resolved Hide resolved
src/gval/accessors/gval_xarray.py Show resolved Hide resolved
src/gval/accessors/gval_xarray.py Outdated Show resolved Hide resolved
src/gval/comparison/compute_categorical_metrics.py Outdated Show resolved Hide resolved
tests/test_catalogs.py Outdated Show resolved Hide resolved
src/gval/accessors/gval_xarray.py Show resolved Hide resolved
@fernando-aristizabal fernando-aristizabal merged commit 224e333 into main Oct 12, 2023
4 checks passed
@fernando-aristizabal fernando-aristizabal deleted the tabulation_performance branch October 12, 2023 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants