Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use existing docker ApiClient instance instead of creating a new one #504

Merged
merged 2 commits into from
Jan 30, 2024

Conversation

aaraney
Copy link
Member

@aaraney aaraney commented Jan 25, 2024

Use existing docker ApiClient instance instead of creating a new one.

scheduler tests were failing using docker desktop. see docker/docker-py#3198 and docker/docker-py#3219 for more detail. the gist is docker creates a context for docker desktop that uses a separate, non-default unix socket. for docker-py to play nicely with docker desktop, you must set DOCKER_HOST to the appropriate unix socket. You can locate the appropriate socket addr using: docker context inspect $(docker context show) | awk -F '"' '/"Host"/ {print $4}'.

dmod.scheduler -- 0.10.2

Changes

  • use existing docker ApiClient instance instead of creating a new one

@christophertubbs christophertubbs merged commit 037c0d3 into NOAA-OWP:master Jan 30, 2024
4 checks passed
@aaraney aaraney mentioned this pull request May 5, 2024
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants