Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade GUI django version #209

Closed
aaraney opened this issue Oct 28, 2022 · 5 comments · Fixed by #585
Closed

Upgrade GUI django version #209

aaraney opened this issue Oct 28, 2022 · 5 comments · Fixed by #585
Assignees
@christophertubbs @robertbartel
Labels
dependencies Pull requests that update a dependency file maas MaaS Workstream question Further information is requested

Comments

@aaraney
Copy link
Member

aaraney commented Oct 28, 2022

In trying to debug some things during development, I noticed that we have pinned the gui's django version to 2.2.28, the latest stable release of django is 4.1.2. Is there a reason we have not updated this @christophertubbs / @robertbartel?

DMOD/python/gui/dependencies.txt

Line 4 in 4b02fee

Django==2.2.28

@aaraney aaraney added question Further information is requested dependencies Pull requests that update a dependency file labels Oct 28, 2022
@christophertubbs
Copy link
Contributor

I have an upgrade for it in the branch I'm working on. There are some things that have to be switched out (mostly switching from url objects to re_path objects in url routing), but it's not too painful. I imagine the entry in the dependencies is just from a pip freeze.

aaraney added a commit to aaraney/DMOD that referenced this issue Oct 28, 2022
@aaraney
date time field accepts partial ISO8061 format. this is a work around…
3512ad4 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
@aaraney
Copy link
Member Author

aaraney commented Nov 1, 2022

@christophertubbs, cool cool. Thanks for updating this. Your pip freeze assumption is correct.

@aaraney aaraney mentioned this issue Nov 4, 2022
Merged
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Nov 28, 2022
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
169f5de 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
@robertbartel robertbartel added the maas MaaS Workstream label Dec 28, 2022
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Jan 4, 2023
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
78d84f6 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Jan 5, 2023
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
e2bb715 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Jan 10, 2023
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
8d42ba0 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Jan 18, 2023
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
3d12202 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
robertbartel pushed a commit to robertbartel/DMOD that referenced this issue Jan 18, 2023
@aaraney @robertbartel
date time field accepts partial ISO8061 format. this is a work around…
f6313d7 
…, should be changed once django version has been updated. NOAA-OWP#209 is tracking this
@christophertubbs
Copy link
Contributor

dependencies.txt (weird version of requirements.txt in python/gui) specifies the latest version of 3, but the root requirements.txt doesn't specify a version. I'm running that version locally and everything is hunky dory. We probably want to make sure that's updated in the dependencies.txt and that it's limited to ~=4.0 since we're good this time but we might get hurt if it decides to pull 5.0+ at some point.

@aaraney
Copy link
Member Author

aaraney commented Apr 19, 2024

Related question to your comment, @christophertubbs, can we get rid of dependencies.txt?

@christophertubbs christophertubbs mentioned this issue Apr 19, 2024
Merged
@christophertubbs
Copy link
Contributor

Not atm because of how the gui's docker image is built.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophertubbs christophertubbs

@robertbartel robertbartel

Labels
dependencies Pull requests that update a dependency file maas MaaS Workstream question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pinned versions of gunicorn and Django christophertubbs/DMOD
3 participants
@christophertubbs @robertbartel @aaraney