Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update submodule pointer for fv3atm / ccpp-physics #52

Conversation

climbfuji
Copy link

@climbfuji climbfuji commented Dec 16, 2020

This PR updates the submodule pointer for fv3atm/ccpp-physics for the changes described in NOAA-GSL/ccpp-physics#67.

Associated PRs:

NOAA-GSL/ccpp-physics#67
NOAA-GSL/fv3atm#63
#52

For regression testing, see below.

@DomHeinzeller
Copy link

Regression testing on Hera with Intel using rt.conf against existing EMC baseline: The following tests fail (because of previous updates to the GSL physics), but run to completion

fv3_ccpp_gsd
fv3_ccpp_rap
fv3_ccpp_hrrr
fv3_ccpp_rrfs_v1beta
fv3_ccpp_gsd_debug
fv3_ccpp_gsd_diag3d_debug
fv3_ccpp_rrfs_v1beta_debug

rt_hera_intel.log

@DomHeinzeller
Copy link

Regression testing on Hera with GNU using rt_gnu.conf against existing EMC baseline: The following tests fail (because of previous updates to the GSL physics), but run to completion

fv3_ccpp_rrfs_v1beta
fv3_ccpp_gsd

rt_hera_gnu.log

@DomHeinzeller
Copy link

Regression testing on Hera with Intel using rt_ccpp_dev.conf: first create baseline, then verify against it - all tests pass.

rt_hera_intel_ccpp_dev_create.log
rt_hera_intel_ccpp_dev_verify.log

@climbfuji climbfuji force-pushed the gsl_develop_mynnsfc_bugfix_20201216 branch from c8c5598 to 86668a3 Compare December 16, 2020 20:38
@DomHeinzeller DomHeinzeller merged commit d5fa4c1 into NOAA-GSL:gsl/develop Dec 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants