forked from NCAR/ccpp-physics
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rucice with bugfixes (replaces #57) #63
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ice is added to sfc_drv_ruc.F90.
parameters of lsm_ruc_run. There are not needed there because initialization of RUC soil variables is done now in lsm_ruc_init.
…emove unneeded acsnow
Suggested changes to rucice PR
This was referenced Nov 24, 2020
Replaced by #65 |
zhanglikate
pushed a commit
to zhanglikate/ccpp-physics
that referenced
this pull request
Mar 1, 2024
add canopy heat and optional to noahmpdrv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces #57 - it contains all of its changes (see description there), and additionally bug fixes for uninitialized variables in RUC LSM and updates to MYNN surface layer to work with RUC ICE.
Associated PRs
#57 (contained in #63)
#63
NOAA-GSL/fv3atm#54 (contained in NOAA-GSL/fv3atm#56)
NOAA-GSL/fv3atm#56
NOAA-GSL/ufs-weather-model#47
For regression testing information, see NOAA-GSL/ufs-weather-model#47.